-
Notifications
You must be signed in to change notification settings - Fork 638
chore: fix filenames and format in changelog unclog files #2827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andynog
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
melekes
approved these changes
Apr 17, 2024
mergify bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
I've just spotted several problems in our changelog unclog data (one of them long-standing!). This PR fixes them. The backport to `v0.38.x` and `v0.37.x` will only be partial (only the entry fixed on `v0.37.0`). --- #### PR checklist - [ ] ~~Tests written/updated~~ - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code comments~~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec Co-authored-by: Andy Nogueira <me@andynogueira.dev> (cherry picked from commit b846639)
mergify bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
I've just spotted several problems in our changelog unclog data (one of them long-standing!). This PR fixes them. The backport to `v0.38.x` and `v0.37.x` will only be partial (only the entry fixed on `v0.37.0`). --- #### PR checklist - [ ] ~~Tests written/updated~~ - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code comments~~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec Co-authored-by: Andy Nogueira <me@andynogueira.dev> (cherry picked from commit b846639) # Conflicts: # .changelog/unreleased/improvements/2328-e2e-log-sent-txs.md
This was referenced Apr 18, 2024
mergify bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
I've just spotted several problems in our changelog unclog data (one of them long-standing!). This PR fixes them. The backport to `v0.38.x` and `v0.37.x` will only be partial (only the entry fixed on `v0.37.0`). --- #### PR checklist - [ ] ~~Tests written/updated~~ - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code comments~~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec Co-authored-by: Andy Nogueira <me@andynogueira.dev> (cherry picked from commit b846639) # Conflicts: # .changelog/v0.37.5/improvements/2328-e2e-log-sent-txs.md # .changelog/v0.37.5/improvements/2788-move-ws-info-log-to-debug.md
4 tasks
melekes
pushed a commit
that referenced
this pull request
Apr 18, 2024
…2827) (#2835) I've just spotted several problems in our changelog unclog data (one of them long-standing!). This PR fixes them. The backport to `v0.38.x` and `v0.37.x` will only be partial (only the entry fixed on `v0.37.0`). --- #### PR checklist - [ ] ~~Tests written/updated~~ - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code comments~~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #2827 done by [Mergify](https://mergify.com). Co-authored-by: Sergio Mena <sergio@informal.systems>
melekes
added a commit
that referenced
this pull request
Apr 18, 2024
…2827) (#2837) I've just spotted several problems in our changelog unclog data (one of them long-standing!). This PR fixes them. The backport to `v0.38.x` and `v0.37.x` will only be partial (only the entry fixed on `v0.37.0`). --- #### PR checklist - [ ] ~~Tests written/updated~~ - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code comments~~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #2827 done by [Mergify](https://mergify.com). --------- Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
melekes
added a commit
that referenced
this pull request
Apr 18, 2024
…2827) (#2836) I've just spotted several problems in our changelog unclog data (one of them long-standing!). This PR fixes them. The backport to `v0.38.x` and `v0.37.x` will only be partial (only the entry fixed on `v0.37.0`). --- #### PR checklist - [ ] ~~Tests written/updated~~ - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code comments~~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #2827 done by [Mergify](https://mergify.com). --------- Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-to-v0.37.x
Tell Mergify to backport the PR to v0.37.x
backport-to-v0.38.x
Tell Mergify to backport the PR to v0.38.x
backport-to-v1.x
Tell Mergify to backport the PR to v1.x
chore
documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just spotted several problems in our changelog unclog data (one of them long-standing!).
This PR fixes them.
The backport to
v0.38.x
andv0.37.x
will only be partial (only the entry fixed onv0.37.0
).PR checklist
Tests written/updated.changelog
(we use unclog to manage our changelog)Updated relevant documentation (docs/
orspec/
) and code comments