8000 chore: fix filenames and format in changelog unclog files by sergio-mena · Pull Request #2827 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: fix filenames and format in changelog unclog files #2827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

sergio-mena
Copy link
Contributor
@sergio-mena sergio-mena commented Apr 16, 2024

I've just spotted several problems in our changelog unclog data (one of them long-standing!).

This PR fixes them.

The backport to v0.38.x and v0.37.x will only be partial (only the entry fixed on v0.37.0).


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments
  • Title follows the Conventional Commits spec

@sergio-mena sergio-mena requested review from a team as code owners April 16, 2024 18:56
@sergio-mena sergio-mena self-assigned this Apr 16, 2024
@sergio-mena sergio-mena added documentation Improvements or additions to documentation chore backport-to-v0.37.x Tell Mergify to backport the PR to v0.37.x backport-to-v0.38.x Tell Mergify to backport the PR to v0.38.x backport-to-v1.x Tell Mergify to backport the PR to v1.x labels Apr 16, 2024
Copy link
Contributor
@andynog andynog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@melekes melekes added this pull request to the merge queue Apr 18, 2024
Merged via the queue into main with commit b846639 Apr 18, 2024
38 checks passed
@melekes melekes deleted the sergio/fix-changelog-problems branch April 18, 2024 05:17
mergify bot pushed a commit that referenced this pull request Apr 18, 2024
I've just spotted several problems in our changelog unclog data (one of
them long-standing!).

This PR fixes them.

The backport to `v0.38.x` and `v0.37.x` will only be partial (only the
entry fixed on `v0.37.0`).

---

#### PR checklist

- [ ] ~~Tests written/updated~~
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code
comments~~
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

Co-authored-by: Andy Nogueira <me@andynogueira.dev>
(cherry picked from commit b846639)
mergify bot pushed a commit that referenced this pull request Apr 18, 2024
I've just spotted several problems in our changelog unclog data (one of
them long-standing!).

This PR fixes them.

The backport to `v0.38.x` and `v0.37.x` will only be partial (only the
entry fixed on `v0.37.0`).

---

#### PR checklist

- [ ] ~~Tests written/updated~~
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code
comments~~
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

Co-authored-by: Andy Nogueira <me@andynogueira.dev>
(cherry picked from commit b846639)

# Conflicts:
#	.changelog/unreleased/improvements/2328-e2e-log-sent-txs.md
mergify bot pushed a commit that referenced this pull request Apr 18, 2024
I've just spotted several problems in our changelog unclog data (one of
them long-standing!).

This PR fixes them.

The backport to `v0.38.x` and `v0.37.x` will only be partial (only the
entry fixed on `v0.37.0`).

---

#### PR checklist

- [ ] ~~Tests written/updated~~
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code
comments~~
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

Co-authored-by: Andy Nogueira <me@andynogueira.dev>
(cherry picked from commit b846639)

# Conflicts:
#	.changelog/v0.37.5/improvements/2328-e2e-log-sent-txs.md
#	.changelog/v0.37.5/improvements/2788-move-ws-info-log-to-debug.md
melekes pushed a commit that referenced this pull request Apr 18, 2024
…2827) (#2835)

I've just spotted several problems in our changelog unclog data (one of
them long-standing!).

This PR fixes them.

The backport to `v0.38.x` and `v0.37.x` will only be partial (only the
entry fixed on `v0.37.0`).

---

#### PR checklist

- [ ] ~~Tests written/updated~~
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code
comments~~
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
<hr>This is an automatic backport of pull request #2827 done by
[Mergify](https://mergify.com).

Co-authored-by: Sergio Mena <sergio@informal.systems>
melekes added a commit that referenced this pull request Apr 18, 2024
…2827) (#2837)

I've just spotted several problems in our changelog unclog data (one of
them long-standing!).

This PR fixes them.

The backport to `v0.38.x` and `v0.37.x` will only be partial (only the
entry fixed on `v0.37.0`).

---

#### PR checklist

- [ ] ~~Tests written/updated~~
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code
comments~~
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
<hr>This is an automatic backport of pull request #2827 done by
[Mergify](https://mergify.com).

---------

Co-authored-by: Sergio Mena <sergio@informal.systems>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
melekes added a commit that referenced this pull request Apr 18, 2024
…2827) (#2836)

I've just spotted several problems in our changelog unclog data (one of
them long-standing!).

This PR fixes them.

The backport to `v0.38.x` and `v0.37.x` will only be partial (only the
entry fixed on `v0.37.0`).

---

#### PR checklist

- [ ] ~~Tests written/updated~~
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code
comments~~
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
<hr>This is an automatic backport of pull request #2827 done by
[Mergify](https://mergify.com).

---------

Co-authored-by: Sergio Mena <sergio@informal.systems>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v0.37.x Tell Mergify to backport the PR to v0.37.x backport-to-v0.38.x Tell Mergify to backport the PR to v0.38.x backport-to-v1.x Tell Mergify to backport the PR to v1.x chore documentation Improvements or additions to documentation
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants
0