10000 refactor(blocksync): break up `poolRoutine` by melekes · Pull Request #2820 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(blocksync): break up poolRoutine #2820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 24, 2024
Merged

refactor(blocksync): break up poolRoutine #2820

merged 7 commits into from
Apr 24, 2024

Conversation

melekes
Copy link
Contributor
@melekes melekes commented Apr 16, 2024 •
edited
Loading

Replaces #2152

Co-authored by: @faddat

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments
  • Title follows the Conventional Commits spec

@melekes melekes requested review from a team as code owners April 16, 2024 07:12
@melekes melekes self-assigned this Apr 16, 2024
@melekes melekes changed the title refactor(blocksync): break up poolRoutine refactor(blocksync): break up poolRoutine Apr 16, 2024
@melekes melekes mentioned this pull request Apr 16, 2024
Closed
4 tasks
@melekes melekes added the hygiene Any work relating to code legibility/hygiene to make it easier to read label Apr 16, 2024
@melekes

This comment was marked as resolved.

Sign in to view
@faddat
Copy link
Contributor
faddat commented Apr 16, 2024

Hey thank you for the fixes @melekes !

@adizere adizere added this to the 2024-Q2 milestone Apr 18, 2024
cason
cason approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor
@cason cason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

I could reproduce the changes in the original code, and the behavior matches.

@melekes melekes enabled auto-merge April 24, 2024 05:24
@melekes melekes added this pull request to the merge queue Apr 24, 2024
Merged via the queue into main with commit 3cce60e Apr 24, 2024
35 checks passed
@melekes melekes deleted the anton/simplify-pool-routine branch April 24, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cason cason cason approved these changes

Assignees

@melekes melekes

@sergio-mena sergio-mena

Labels
hygiene Any work relating to code legibility/hygiene to make it easier to read
Projects
No open projects
CometBFT
Status: Done
Milestone
2024-Q2
Development

Successfully merging this pull request may close these issues.
5 participants
@melekes @faddat @cason @adizere @sergio-mena
0