8000 spec: added missing hyperlink and some clean-up on ABCI spec by andynog · Pull Request #2680 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

spec: added missing hyperlink and some clean-up on ABCI spec #2680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 27, 2024
Merged

spec: added missing hyperlink and some clean-up on ABCI spec #2680

merged 5 commits into from
Mar 27, 2024

Conversation

andynog
Copy link
Contributor
@andynog andynog commented Mar 26, 2024

close: #2679

Added hyperlink and cleaned-up hidden comments

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments
  • Title follows the Conventional Commits spec

@andynog andynog added abci Application blockchain interface spec Specification-related labels Mar 26, 2024
@andynog andynog added this to the 2024-Q1 milestone Mar 26, 2024
@andynog andynog self-assigned this Mar 26, 2024
@andynog andynog requested review from a team as code owners March 26, 2024 19:37
@andynog andynog changed the title spec: ABCI App requirements file - added hyperlink and some clean-up spec: ABCI Requirements for the Application - added missing hyperlink and some clean-up Mar 26, 2024
@andynog andynog requested review from sergio-mena and cason March 26, 2024 19:46
@andynog andynog changed the title spec: ABCI Requirements for the Application - added missing hyperlink and some clean-up spec: added missing hyperlink and some clean-up on ABCI spec Mar 26, 2024
sergio-mena
sergio-mena reviewed Mar 27, 2024
View reviewed changes
sergio-mena
sergio-mena reviewed Mar 27, 2024
View reviewed changes
@andynog @sergio-mena
Update spec/abci/abci++_app_requirements.md
07fcad8 
Co-authored-by: Sergio Mena <sergio@informal.systems>
@andynog andynog merged commit 9606d28 into v0.38.x Mar 27, 2024
@andynog andynog deleted the andy/2679-fix-spec-abci-params branch March 27, 2024 12:53
@andynog andynog mentioned this pull request Mar 27, 2024
Closed
@adizere adizere removed this from the 2024-Q1 milestone Mar 27, 2024
@faddat faddat mentioned this pull request Oct 15, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergio-mena sergio-mena sergio-mena approved these changes

@cason cason Awaiting requested review from cason

Assignees

@andynog andynog

Labels
abci Application blockchain interface spec Specification-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andynog @sergio-mena @adizere
0