8000 feat(blocksync): sort peers by download rate & multiple requests for closer blocks by melekes · Pull Request #2475 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(blocksync): sort peers by download rate & multiple requests for closer blocks #2475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 11, 2024
Merged

feat(blocksync): sort peers by download rate & multiple requests for closer blocks #2475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7a7f80d
redo the request immediately upon receiving NoBlockResponse
melekes Feb 29, 2024
2e323c3
use time.After instead of timer
melekes Feb 29, 2024
70526b1
assign requests to fast peers first
melekes Feb 29, 2024
2674481
request a block from 2nd peer if < 25 blocks away
melekes Mar 5, 2024
26a5db9
bring back RedoRequest to make PR backwards compatible
melekes Mar 5, 2024
66784b9
add changelog entries
melekes Mar 5, 2024
2ec4700
change values based on Osmosis recommendations
melekes Mar 6, 2024
7595125
remove maxDiffBetweenCurrentAndReceivedBlockHeight
melekes Mar 6, 2024
a4ae42e
remove the peer if it sends us invalid block
melekes Mar 6, 2024
ce60c7b
disconnect from peer if block is less than startHeight
melekes Mar 6, 2024
e97007f
actually request blocks from 2nd peer
melekes Mar 6, 2024
dfeb091
wait 3 sec before scheduling requests to connect to more peers
melekes Mar 7, 2024
eefe7bc
amend changelog entry
melekes Mar 7, 2024
9bed615
Merge branch 'main' into anton/2379-blocksync-improv
melekes Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/unreleased/improvements/2475-blocksync-2nd-request.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- `[blocksync]` Request a block from peer B if we are approaching pool's height
(less than 50 blocks) and the current peer A is slow in sending us the
block [\#2475](https://github.com/cometbft/cometbft/pull/2475)
3 changes: 3 additions & 0 deletions .changelog/unreleased/improvements/2475-blocksync-no-block-response.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- `[blocksync]` Request the block N from peer B immediately after getting
`NoBlockResponse` from peer A
[\#2475](https://github.com/cometbft/cometbft/pull/2475)
2 changes: 2 additions & 0 deletions .changelog/unreleased/improvements/2475-blocksync-sort-peers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[blocksync]` Sort peers by download rate (the fastest peer is picked first)
[\#2475](https://github.com/cometbft/cometbft/pull/2475)
Loading
0