10000 p2p: add a per-message type send and receive metric (backport #9622) by jmalicevic · Pull Request #230 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

p2p: add a per-message type send and receive metric (backport #9622) #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Jan 31, 2023
Merged

p2p: add a per-message type send and receive metric (backport #9622) #230

merged 39 commits into from
Jan 31, 2023

Conversation

jmalicevic
Copy link
Contributor
@jmalicevic jmalicevic commented Jan 29, 2023 •
edited
Loading

This is a backport of tendermint/tendermint#9622. Original PR tendermint/tendermint#9640 .

Addresses #219 .

williambanfield and others added 30 commits October 27, 2022 19:47
@williambanfield @mergify
p2p: add a per-message type send and receive metric (#9622)
97a6c38 
* p2p: ressurrect the p2p envelope and use to calculate message metric

Co-authored-by: Callum Waters <cmwaters19@gmail.com>
(cherry picked from commit 09b8708)

# Conflicts:
#	cmd/tendermint/commands/rollback.go
#	go.mod
#	go.sum
#	p2p/peer.go
#	p2p/peer_set_test.go
@williambanfield
all builds except fuzz
79a7d6d
@williambanfield
all builds except fuzz
89482f8
@williambanfield
New methods call the old methods
12bf141
@williambanfield
Receive called from OnReceive
cef631d
@williambanfield
tests build after reintroducing send and receive
0b2202e
@williambanfield
fix fuzz peer
af054f1
@williambanfield
nolint gosec
e744325
@williambanfield
mocks use the 'New' calls
6986c21
@williambanfield
move nolint
e07e7c9
@williambanfield
NewReceive called conditionally from switch
ed6ef40
@williambanfield
add receives to all with NewReceive
9aaacd7
@williambanfield
all reactors have receive with empty new receive call
3e111ac
@williambanfield
reactors have channel and peer in new receive
39b2e4b
@williambanfield
add proto message unmarshal to reactors
1d20f37
@williambanfield
unwrap messages in receive calls
bc62cfe
@williambanfield
add channel types where absent
cc9e8f4
@williambanfield
fix mempool reactor to include Receive
10dca9f
@williambanfield
unwrap messages in receive calls
bbb5051
@williambanfield
remove erroneously added blockchain reactors
ad8aa2b
@williambanfield
Merge remote-tracking branch 'origin/v0.37.x' into mergify/bp/v0.37.x…
18adc25 
…/pr-9622
@williambanfield
remove erroneously added maverick reactor
bdb9fcc
@williambanfield
re-add broadcast method
deaf1a9
@williambanfield
Rename new methods to *Envelope instead of New*
4b96c40
@williambanfield
add deprecation notices
ad14bf1
@williambanfield
fix typos
3302345
@williambanfield
document new metrics
3ce5e29
@williambanfield
format after sed changes
59f56b3
@williambanfield
remove erroneous broadcast method name update
9be4f46
@williambanfield
remove old receives
648393b
@jmalicevic jmalicevic self-assigned this Jan 29, 2023
@jmalicevic jmalicevic mentioned this pull request Jan 29, 2023
Closed
7 tasks
@jmalicevic jmalicevic marked this pull request as ready for review January 29, 2023 21:56
@jmalicevic jmalicevic requested review from a team as code owners January 29, 2023 21:56
@jmalicevic
Copy link
Contributor Author

I would add a changelog entry for this change, seems like a not so minor change to developers.

@thanethomson
Copy link
Contributor

I would add a changelog entry for this change, seems like a not so minor change to developers.

Agreed! I'd say the major change here is the replacement of the Send and TrySend methods in the Peer interface with SendEnvelope and TrySendEnvelope: h 8000 ttps://github.com/cometbft/cometbft/pull/230/files#diff-56fdd197da1151147beaf6e468b618992fb58797786d85dfe2c2c6a42515d94e

@jmalicevic jmalicevic merged commit 9eaefb4 into v0.37.x Jan 31, 2023
@jmalicevic jmalicevic deleted the mergify/bp/v0.37.x/pr-9622 branch January 31, 2023 22:21
@faddat faddat mentioned this pull request Jan 5, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thanethomson thanethomson thanethomson approved these changes

Assignees

@jmalicevic jmalicevic

Labels
metrics p2p
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmalicevic @thanethomson @williambanfield
0