10000 refactor(rpc): export rpc package errors by akaladarshi · Pull Request #2200 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(rpc): export rpc package errors #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 43 commits into from
Mar 14, 2024
Merged

refactor(rpc): export rpc package errors #2200

merged 43 commits into from
Mar 14, 2024

Conversation

akaladarshi
Copy link
Contributor

This PR Contributes to: #1140

Changes:

  • Exports errors for rpc package

@akaladarshi akaladarshi requested review from a team as code owners January 31, 2024 03:02
mzabaluev
mzabaluev reviewed Jan 31, 2024
View reviewed changes
mzabaluev
mzabaluev reviewed Jan 31, 2024
View reviewed changes
@mzabaluev
Copy link
Contributor

Also, how is this a "chore"? It's an improvement changing the API.

@mzabaluev mzabaluev changed the title chore: export rpc package errors refactor(rpc): export rpc package errors Jan 31, 2024
@akaladarshi akaladarshi requested a review from mzabaluev February 2, 2024 14:07
@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale For use by stalebot label Feb 13, 2024
@akaladarshi akaladarshi force-pushed the akaladarshi/export-rpc-errors branch from 0c246cf to 84ee8a1 Compare February 13, 2024 04:32
@github-actions github-actions bot removed the stale For use by stalebot label Feb 14, 2024
@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale For use by stalebot label Feb 25, 2024
@akaladarshi
Copy link
Contributor Author

@mzabaluev Hi, please can you please again review the changes.

@github-actions github-actions bot removed the stale For use by stalebot label Feb 26, 2024
@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale For use by stalebot label Mar 11, 2024
@github-actions github-actions bot removed the stale For use by stalebot label Mar 12, 2024
@andynog andynog added rpc P:tech-debt Priority: Technical debt that needs to be paid off to enable us to move faster, reliably labels Mar 12, 2024
andynog added 17 commits March 13, 2024 14:55
@andynog
fix typo
846a2c0
@andynog
fix typo
ae3a981
@andynog
follow naming convention use Source instead of Err
472d8c8
@andynog
follow naming convention use Source instead of Err
f0231d1
@andynog
follow naming convention use Source instead of Err
a99f399
@andynog
follow naming convention use Source instead of Err
1078e9b
@andynog
follow naming convention use Source instead of Err
a994dcb
@andynog
better message description
519f34e
@andynog
added Unwrap method to ErrServiceConfig error (cometbft#2200)
c5c8672
@andynog
added Unwrap to ErrValidation, replace any field with string (cometbf…
9cb5a45 
…t#2200)
@andynog
better field names for ErrQueryLength (cometbft#2200)
30c1051
@andynog
export all errors in core (cometbft#2200)
d8a2624
@andynog
replace any with []byte (cometbft#2200)
c62faa0
@andynog
created a custom error for min height gt max height (cometbft#2200)
2870317
@andynog
refactored the ErrTxBroadcast error (cometbft#2200)
ae8360c
@andynog
added tx hash to ErrSubFailed and renamed error (cometbft#2200)
b97e5aa
@andynog
added CHANGELOG entry (cometbft#2200)
8c86cb9
@andynog andynog requested review from adizere and removed request for mzabaluev March 13, 2024 21:10
andynog
andynog approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor
@andynog andynog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code lgtm, refactored and changed code based on suggestions and comments. Need one additional approval then it can be merged.

adizere
adizere approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member
@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akaladarshi and @andynog for shepherding this PR.

Left minor comments. Looks ready otherwise!

@andynog andynog added this pull request to the merge queue Mar 14, 2024
Merged via the queue into cometbft:main with commit 72450bc Mar 14, 2024
@akaladarshi akaladarshi deleted the akaladarshi/export-rpc-errors branch March 15, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzabaluev mzabaluev mzabaluev left review comments

@adizere adizere adizere approved these changes

@glnro glnro glnro left review comments

@andynog andynog andynog approved these changes

Assignees

@andynog andynog

Labels
P:tech-debt Priority: Technical debt that needs to be paid off to enable us to move faster, reliably rpc
Projects
No open projects
CometBFT
Status: Done
Milestone
2024-Q1
Development

Successfully merging this pull request may close these issues.
5 participants
@akaladarshi @mzabaluev @andynog @adizere @glnro
0