8000 Fixes the and removes other networks. by lasarojc · Pull Request #200 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixes the and removes other networks. #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2023
Merged

Fixes the and removes other networks. #200

merged 1 commit into from
Jan 25, 2023

Conversation

lasarojc
Copy link
Contributor
@lasarojc lasarojc commented Jan 25, 2023 •
edited
Loading

Fixes the networks/local/localnode/wrapper.sh and removes other networks and corresponding documentation.

PR checklist

  • Tests written/updated, or no tests needed
  • CHANGELOG_PENDING.md updated, or no changelog entry needed
  • Updated relevant documentation (docs/) and code comments, or no
    documentation updates needed

@lasarojc lasarojc linked an issue Jan 25, 2023 that may be closed by this pull request
Clean up and do renaming in the network #199
Closed
@lasarojc lasarojc self-assigned this Jan 25, 2023
@lasarojc lasarojc added backport-to-v0.34.x Tell Mergify to backport the PR to v0.34.x backport-to-v0.37.x Tell Mergify to backport the PR to v0.37.x rename Renaming our fork labels Jan 25, 2023
@lasarojc lasarojc marked this pull request as ready for review January 25, 2023 18:14
@lasarojc lasarojc requested a review from a team as a code owner January 25, 2023 18:14
thanethomson
thanethomson approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor
@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really great seeing so many unmaintained/legacy lines of code/config disappearing 🙂 It already reduces the cognitive burden of maintaining this particular codebase.

@lasarojc lasarojc merged commit 5d54939 into main Jan 25, 2023
@lasarojc lasarojc deleted the lasarojc/199/clean-up-network-folder branch January 25, 2023 19:41
@mergify mergify bot mentioned this pull request Jan 25, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jan 25, 2023
@lasarojc @mergify
Fixes the and removes other networks. (#200)
6b75eeb 
(cherry picked from commit 5d54939)

# Conflicts:
#	docs/networks/terraform-and-ansible.md
#	networks/remote/README.md
#	networks/remote/ansible/roles/logzio/tasks/main.yml
@mergify mergify bot mentioned this pull request Jan 25, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jan 25, 2023
@lasarojc @mergify
Fixes the and removes other networks. (#200)
88f8d15 
(cherry picked from commit 5d54939)

# Conflicts:
#	docs/networks/terraform-and-ansible.md
#	networks/remote/README.md
#	networks/remote/ansible/config.yml
#	networks/remote/ansible/logzio.yml
#	networks/remote/ansible/roles/logzio/tasks/main.yml
lasarojc added a commit that referenced this pull request Jan 26, 2023
@mergify @lasarojc
Fixes the and removes other networks. (backport #200) (#201)
b51d537 
* Fixes the  and removes other networks. (#200)

(cherry picked from commit 5d54939)

# Conflicts:
#	docs/networks/terraform-and-ansible.md
#	networks/remote/README.md
#	networks/remote/ansible/roles/logzio/tasks/main.yml

* Resolving backport conflicts

Co-authored-by: Lasaro <lasaro@informal.systems>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
lasarojc added a commit that referenced this pull request Jan 26, 2023
@mergify @lasarojc
Fixes the and removes other networks. (backport #200) (#202)
3351d19 
* Fixes the  and removes other networks. (#200)

(cherry picked from commit 5d54939)

# Conflicts:
#	docs/networks/terraform-and-ansible.md
#	networks/remote/README.md
#	networks/remote/ansible/config.yml
#	networks/remote/ansible/logzio.yml
#	networks/remote/ansible/roles/logzio/tasks/main.yml

* Resolve mergify backport conflicts

Co-authored-by: Lasaro <lasaro@informal.systems>
@faddat faddat mentioned this pull request Jan 5, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thanethomson thanethomson thanethomson approved these changes

Assignees

@lasarojc lasarojc

Labels
backport-to-v0.34.x Tell Mergify to backport the PR to v0.34.x backport-to-v0.37.x Tell Mergify to backport the PR to v0.37.x rename Renaming our fork
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up and do renaming in the network
2 participants
@lasarojc @thanethomson
0