fix: make TestMempoolProgressInHigherRound less flaky #1953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wrangling.... will mark this as draft. |
|
That's right draft is a good way for this one. |
faddat
commented
Jan 5, 2024
cason
reviewed
Jan 8, 2024
privval/socket_listeners_test.go
Outdated
There was a problem hiding this comment.
Are these changes somehow related with the mempool test?
| ensureNewRound(newRoundCh, height, round) // first round at first height | ||
| ensureNewEventOnChannel(newBlockCh) // first block gets committed | ||
| // Ensure new round at first height and block commit | ||
| ensureNewRound(newRoundCh, height, round) |
There was a problem hiding this comment.
The problem here is that the new round event takes more than 200ms?
There was a problem hiding this comment.
These are both good questions that I had missed. I will review this tomorrow and thank you for your review.
Also, yes I think so.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should make TestMempoolProgressInHigherRound less flaky and a teensy big more rigorous.
The critical change is the order of the steps in the test itself, which does seem to make the test more reliable.
If the order should not have changed then we should probably just close this PR and try to find another way to make the test more reliable.
closes: #1932
found in: #1954
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments