8000 fix TestListenerTimeoutReadWrite by faddat · Pull Request #1947 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix TestListenerTimeoutReadWrite #1947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 7, 2024
Merged

fix TestListenerTimeoutReadWrite #1947

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8a4b685
fix TestListenerTimeoutReadWrite
faddat Jan 2, 2024
568ba49
Merge branch 'main' into faddat/testlistenertimeoutreadwrite
faddat Jan 3, 2024
d6995ae
Merge branch 'main' into faddat/testlistenertimeoutreadwrite
faddat Jan 4, 2024
7e8b149
Merge branch 'main' into faddat/testlistenertimeoutreadwrite
faddat Jan 5, 2024
15d6f79
restore comments
faddat Jan 5, 2024
0286f38
do it 100x. Treat every test failure as a bug.
faddat Jan 5, 2024
a20a7ad
Merge branch 'main' into faddat/testlistenertimeoutreadwrite
faddat Jan 7, 2024
c8a7e49
don't do it a hundred times
faddat Jan 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion privval/socket_listeners_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,16 @@ func TestListenerTimeoutReadWrite(t *testing.T) {
// Note: this controls how long this test actually runs.
timeoutReadWrite = 10 * time.Millisecond
)

for _, tc := range listenerTestCases(t, timeoutAccept, timeoutReadWrite) {
go func(dialer SocketDialer) {
_, err := dialer()
conn, err := dialer()
if err != nil {
panic(err)
}
// Add a delay before closing the connection
time.Sleep(2 * timeoutReadWrite)
conn.Close()
}(tc.dialer)

c, err := tc.listener.Accept()
Expand Down
0