10000 chore(spec): specify which fields must be deterministic (backport #1804) by mergify[bot] · Pull Request #1813 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(spec): specify which fields must be deterministic (backport #1804) #1813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 13, 2023
Merged

chore(spec): specify which fields must be deterministic (backport #1804) #1813

merged 2 commits into from
Dec 13, 2023

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Dec 13, 2023

This is an automatic backport of pull request #1804 done by Mergify.
Cherry-pick of 7c6951f has failed:

On branch mergify/bp/v0.38.x/pr-1804
Your branch is up to date with 'origin/v0.38.x'.

You are currently cherry-picking commit 7c6951feb.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   proto/cometbft/abci/v1/types.proto
	both modified:   spec/abci/abci++_basic_concepts.md
	both modified:   spec/abci/abci++_methods.md

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@melekes @mergify
chore(spec): specify which fields must be deterministic (#1804)
502fbd8 
* spec: specify which fields must be deterministic

Closes #1622

* proto: add comment to `events` field

* spec: align spec for CheckTx Response with implementation

* change No to N/A in methods not involved in SMR

* change No to N/A in Info method as well

* same for snapshot

(cherry picked from commit 7c6951f)

# Conflicts:
#	proto/cometbft/abci/v1/types.proto
#	spec/abci/abci++_basic_concepts.md
#	spec/abci/abci++_methods.md
@mergify mergify bot requested review from a team as code owners December 13, 2023 01:04
@mergify mergify bot added the conflicts label Dec 13, 2023
@melekes melekes merged commit 4ba0e2b into v0.38.x Dec 13, 2023
@melekes melekes deleted the mergify/bp/v0.38.x/pr-1804 branch December 13, 2023 01:31
@faddat faddat mentioned this pull request Oct 15, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melekes melekes melekes approved these changes

Assignees
No one assigned
Labels
conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@melekes
0