8000 types: validate Validator#Address field (backport #1715) by mergify[bot] · Pull Request #1721 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

types: validate Validator#Address field (backport #1715) #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2023
Merged

types: validate Validator#Address field (backport #1715) #1721

merged 2 commits into from
Dec 2, 2023

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Dec 1, 2023

This is an automatic backport of pull request #1715 done by Mergify.
Cherry-pick of 63fe7bf has failed:

On branch mergify/bp/v0.38.x/pr-1715
Your branch is up to date with 'origin/v0.38.x'.

You are currently cherry-picking commit 63fe7bf67.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   .changelog/unreleased/improvements/1715-validate-validator-address
	modified:   types/validator.go
	modified:   types/validator_set_test.go
	modified:   types/validator_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   state/store_test.go
	both modified:   store/store_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@melekes @mergify
types: validate Validator#Address field (#1715)
b83bdb0 
* types: validate Validator#Address field

* fix TestProposerSelection3

* add a changelog entry

* fix two more tests

* Update .changelog/unreleased/improvements/1715-validate-validator-address

Co-authored-by: Thane Thomson <connect@thanethomson.com>

---------

Co-authored-by: Thane Thomson <connect@thanethomson.com>
(cherry picked from commit 63fe7bf)

# Conflicts:
#	state/store_test.go
#	store/store_test.go
@mergify mergify bot requested a review from a team as a code owner December 1, 2023 13:57
@mergify mergify bot added the conflicts label Dec 1, 2023
@melekes melekes merged commit 311b5a6 into v0.38.x Dec 2, 2023
@melekes melekes deleted the mergify/bp/v0.38.x/pr-1715 branch December 2, 2023 02:17
@faddat faddat mentioned this pull request Oct 15, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melekes melekes melekes approved these changes

Assignees
No one assigned
Labels
conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@melekes
0