8000 Release v1.0.0-alpha.1 by thanethomson · Pull Request #1710 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Release v1.0.0-alpha.1 #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Dec 4, 2023
Merged

Release v1.0.0-alpha.1 #1710

merged 32 commits into from
Dec 4, 2023

Conversation

thanethomson
Copy link
Contributor
@thanethomson thanethomson commented Nov 30, 2023

Key updated documentation rendered:

Requests to reviewers:

  1. Please check the changelog to see whether we've missed any entries that require special mention in the upgrading guidelines.
  2. Please check that we haven't missed out on any important changelog entries that should be present but aren't (e.g. if you don't see a changelog entry for a PR you know is landing in v1.0.0, please let me know or submit a PR with the base branch as release/v1.0.0-alpha.1).

✅ Manual run of the E2E nightlies: https://github.com/cometbft/cometbft/actions/runs/7064400936


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@thanethomson thanethomson added the release Pull requests that facilitate cutting a release label Nov 30, 2023
@thanethomson thanethomson added this to the 2023-Q4 milestone Nov 30, 2023
@thanethomson thanethomson force-pushed the release/v1.0.0-alpha.1 branch from caaa3b7 to 7df5a97 Compare November 30, 2023 01:17
@thanethomson thanethomson marked this pull request as ready for review November 30, 2023 02:08
@thanethomson thanethomson requested review from a team as code owners November 30, 2023 02:08
lasarojc
Copy link
Contributor
@lasarojc lasarojc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions. LGTM otherwise.

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
thanethomson and others added 8 commits November 30, 2023 17:57
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
…lines

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson force-pushed the release/v1.0.0-alpha.1 branch from 774fb86 to 8f7f516 Compare November 30, 2023 17:58
thanethomson added a commit that referenced this pull request Nov 30, 2023
Remove unreleased entries because they will land in the `v1.0.0-alpha.1`
release in #1710 and will then be ported to `main` in a subsequent PR.

Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson changed the base branch from main to v1.x November 30, 2023 19:05
Signe
629A
d-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Copy link
Contributor
@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

github-merge-queue bot pushed a commit that referenced this pull request Dec 1, 2023
* ci: Add nightly E2E workflow for v1.x branch

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* ci: Enable weekly Dependabot updates for v1.x branch

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* changelog: Remove unreleased entries

Remove unreleased entries because they will land in the `v1.0.0-alpha.1`
release in #1710 and will then be ported to `main` in a subsequent PR.

Signed-off-by: Thane Thomson <connect@thanethomson.com>

---------

Signed-off-by: Thane Thomson <connect@thanethomson.com>
thanethomson and others added 7 commits December 1, 2023 14:34
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
…g v0.7.0)

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Copy link
Contributor
@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member
@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many good things in here, go team! 🥇

@thanethomson thanethomson merged commit 8516a90 into v1.x Dec 4, 2023
@thanethomson thanethomson deleted the release/v1.0.0-alpha.1 branch December 4, 2023 11:55
@thanethomson thanethomson mentioned this pull request Dec 4, 2023
3 tasks
@sergio-mena sergio-mena mentioned this pull request Mar 14, 2024
4 tasks
sergio-mena added a commit that referenced this pull request Mar 18, 2024
Changes in preparation for our second alpha release of `v1.0.0`:

- [CHANGELOG
rendered](https://github.com/cometbft/cometbft/blob/release/v1.0.0-alpha.2/CHANGELOG.md)
- [Manual E2E
run](https://github.com/cometbft/cometbft/actions/runs/8283569894)

IMPORTANT:

The first commit of this PR is manually undoing the `unclog release`
that was performed for `v1.0.0-alpha.1` (#1710). In our release process,
pre-releases do not have their own section in the changelog, so we must
_not_ run `unclog release` when cutting pre-releases (see
`RELEASES.md`).

Therefore, it is advised to exclude the first commit from the diff view
when reviewing this PR.

---

#### PR checklist

- [ ] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [ ] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

---------

Co-authored-by: hvanz <hernan.vanzetto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Pull requests that facilitate cutting a release
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants
0