8000 e2e-v0.38-experimental: Fix flakiness in grpc tests due to pruning (#1492) by jmalicevic · Pull Request #1536 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

e2e-v0.38-experimental: Fix flakiness in grpc tests due to pruning (#1492) #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

jmalicevic
Copy link
Contributor

Manual backport of #1492



PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

* Initial attempt to decrease the flakiness

* Remove loop over blocks from archive nodes

* Removed needless loop through blocks

* removed the first block test (#1492)

---------

Co-authored-by: Andy Nogueira <me@andynogueira.dev>
@jmalicevic jmalicevic added the e2e Related to our end-to-end tests label Oct 25, 2023
@jmalicevic jmalicevic added this to the 2023-Q4 milestone Oct 25, 2023
@jmalicevic jmalicevic self-assigned this Oct 25, 2023
@jmalicevic jmalicevic requested a review from a team as a code owner October 25, 2023 09:19
@jmalicevic jmalicevic mentioned this pull request Oct 25, 2023
17 tasks
@mzabaluev
Copy link
Contributor

Might want to backport the lint fixes as well (in this or separate PR), otherwise looks good.

@jmalicevic jmalicevic merged commit bc4e446 into v0.38.x-experimental Oct 30, 2023
@jmalicevic jmalicevic deleted the jasmina/0.38-exp-e2e-backport-1492 branch October 30, 2023 16:34
lasarojc added a commit that referenced this pull request Nov 13, 2023
* Initial attempt to decrease the flakiness

* Remove loop over blocks from archive nodes

* Removed needless loop through blocks

* removed the first block test (#1492)

---------

Co-authored-by: Andy Nogueira <me@andynogueira.dev>
Co-authored-by: lasaro <lasaro@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Related to our end-to-end tests
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants
0