8000 chore: Update `feature/adr109-reduce-go-api-surface` branch by thanethomson · Pull Request #1508 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: Update feature/adr109-reduce-go-api-surface branch #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

thanethomson
Copy link
Contributor
@thanethomson thanethomson commented Oct 17, 2023

Update the feature/adr109-reduce-go-api-surface branch with the latest changes from main.

To be merged by way of merge commit, not squash-commit.

Do not review individual commits - they have already been reviewed.


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

GoodDaisy and others added 5 commits October 12, 2023 15:01
#1493)

Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.3.0 to 10.0.1.
- [Release notes](https://github.com/python-pillow/Pillow/releases)
- [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst)
- [Commits](python-pillow/Pillow@9.3.0...10.0.1)

---
updated-dependencies:
- dependency-name: pillow
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* proxy: Remove "unsynchronized" local client creator

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* proxy: Expand client creator interface

Expand the `ClientCreator` interface to allow the caller to explicitly
specify the "connection" whose client they are creating. This
potentially gives greater control over the concurrency model employed in
each type of connection.

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* abci/client: Clarify NewLocalClient description

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* proxy: Add connection-synchronized local client creator

Analogous to the old "unsynchronized" local client creator.

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* abci/client: Add unsynchronized local client

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* proxy: Add consensus-synchronized local client creator

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* proxy: Fix mock configuration in test

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add changelog entries

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Remove changelog entry - no longer necessary

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* proxy: Add unsynchronized local client creator

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* changelog: Add entry for unsync local client creator

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Update 1141-abci-unsync-proxy.md

Co-authored-by: Adi Seredinschi <adizere@gmail.com>

---------

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: Adi Seredinschi <adizere@gmail.com>
@thanethomson thanethomson requested review from a team as code owners October 17, 2023 18:54
@thanethomson thanethomson force-pushed the thane/adr109/update-from-main branch from e749f7a to bee5b61 Compare October 17, 2023 18:55
@thanethomson thanethomson marked this pull request as draft October 17, 2023 18:56
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson force-pushed the thane/adr109/update-from-main branch from bee5b61 to 09a5bf6 Compare October 17, 2023 18:59
@thanethomson thanethomson marked this pull request as ready for review October 17, 2023 19:14
@thanethomson thanethomson merged commit 09a5bf6 into feature/adr109-reduce-go-api-surface Oct 18, 2023
@thanethomson thanethomson deleted the thane/adr109/update-from-main branch October 18, 2023 17:07
@andynog andynog added the adr Issue relating to the implementation of a specific ADR label Nov 13, 2023
Copy link
Contributor
mergify bot commented Nov 13, 2023

⚠️ The sha of the head commit of this PR conflicts with #1605. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adr Issue relating to the implementation of a specific ADR
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants
0