8000 fix: docs: default db provider moved from node to config by Plopmenz · Pull Request #1588 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: docs: default db provider moved from node to config #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2023
Merged

fix: docs: default db provider moved from node to config #1588

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c93a043
fix: docs: default db provider moved from node to config
Plopmenz Nov 10, 2023
5c6a2f4
fix: guide: default db provider moved from node to config
Plopmenz Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions docs/guides/go-built-in.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,17 +475,17 @@ In the following code, the application simply returns the unmodified group of tr

return &abcitypes.ResponsePrepareProposal{Txs: proposal.Txs}, nil
}
```
```

This code snippet iterates through the proposed transactions and calculates the `total bytes`. If the `total bytes` exceeds the `MaxTxBytes` specified in the `RequestPrepareProposal` struct, the loop breaks and the transactions processed so far are returned.
This code snippet iterates through the proposed transactions and calculates the `total bytes`. If the `total bytes` exceeds the `MaxTxBytes` specified in the `RequestPrepareProposal` struct, the loop breaks and the transactions processed so far are returned.

Note: It is the responsibility of the application to ensure that the `total bytes` of transactions returned does not exceed the `RequestPrepareProposal.max_tx_bytes` limit.
Note: It is the responsibility of the application to ensure that the `total bytes` of transactions returned does not exceed the `RequestPrepareProposal.max_tx_bytes` limit.

Once a proposed block is received by a node, the proposal is passed to the application to give
its blessing before voting to accept the proposal.
Once a proposed block is received by a node, the proposal is passed to the application to give
its blessing before voting to accept the proposal.

This mechanism may be used for different reasons, for example to deal with blocks manipulated
by malicious nodes, in which case the block should not be considered valid.
This mechanism may be used for different reasons, for example to deal with blocks manipulated
by malicious nodes, in which case the block should not be considered valid.

The following code simply accepts all proposals:

Expand Down Expand Up @@ -586,7 +586,7 @@ func main() {
nodeKey,
proxy.NewLocalClientCreator(app),
nm.DefaultGenesisDocProviderFunc(config),
nm.DefaultDBProvider,
cfg.DefaultDBProvider,
nm.DefaultMetricsProvider(config.Instrumentation),
logger
)
Expand Down Expand Up @@ -676,7 +676,7 @@ node, err := nm.NewNode(
nodeKey,
proxy.NewLocalClientCreator(app),
nm.DefaultGenesisDocProviderFunc(config),
nm.DefaultDBProvider,
cfg.DefaultDBProvider,
nm.DefaultMetricsProvider(config.Instrumentation),
logger)

Expand Down Expand Up @@ -747,7 +747,7 @@ I[2023-04-25|09:08:50.085] service start module=a
...
```

More importantly, the application using CometBFT is producing blocks 🎉🎉 and you can see this reflected in the log output in lines like this:
More importantly, the application using CometBFT is producing blocks 🎉🎉 and you can see this reflected in the log output in lines like this:

```bash
I[2023-04-25|09:08:52.147] received proposal module=consensus proposal="Proposal{2/0 (F518444C0E348270436A73FD0F0B9DFEA758286BEB29482F1E3BEA75330E825C:1:C73D3D1273F2, -1) AD19AE292A45 @ 2023-04-25T12:08:52.143393Z}"
Expand Down
0