ADR-101: Backport pruning mechanism to v0.38.x-experimental #1439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added pruning mechanism for blocks and abci block results * Added support for datacompanion and application retain heights --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Thane Thomson <connect@thanethomson.com>
* Metrics to report on the data companion retain height * Added metric to report the application retain height as well * Added metrics to report the blockstore base height and the abci results base height --------- Co-authored-by: Thane Thomson <connect@thanethomson.com>
* Applied @serigo-mena's comments * Update state/pruner.go Co-authored-by: Thane Thomson <connect@thanethomson.com> * Applied further comments from PR * Fixed batching interval --------- Co-authored-by: Thane Thomson <connect@thanethomson.com>
3 tasks
hvanz
approved these changes
Oct 10, 2023
lasarojc
pushed a commit
that referenced
this pull request
Nov 13, 2023
* ADR 101: Implement pruning mechanism (#1150) * Added pruning mechanism for blocks and abci block results * Added support for datacompanion and application retain heights --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Thane Thomson <connect@thanethomson.com> * Removed extra code added via cherry pick conflicts and regenerated mock * Fixed changelog placement and added entry on pruning mechanism breaking * ADR-101: Metrics to monitor the pruning (#1234) * Metrics to report on the data companion retain height * Added metric to report the application retain height as well * Added metrics to report the blockstore base height and the abci results base height --------- Co-authored-by: Thane Thomson <connect@thanethomson.com> * ADR-101: Pruning mechanism minor fixes (#1246) * Applied @serigo-mena's comments * Update state/pruner.go Co-authored-by: Thane Thomson <connect@thanethomson.com> * Applied further comments from PR * Fixed batching interval --------- Co-authored-by: Thane Thomson <connect@thanethomson.com> * Delete bad changelog entry --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Daniel Cason <daniel.cason@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1422
Backports Commits: commits: 04dfaf5, c710bb8 (metrics for pruning), fe644d8
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments