8000 v0.38.x-experimental: Backport e2e flakiness fix by jmalicevic · Pull Request #1480 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

v0.38.x-experimental: Backport e2e flakiness fix #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2023
Merged

v0.38.x-experimental: Backport e2e flakiness fix #1480

merged 2 commits into from
Oct 13, 2023

Conversation

jmalicevic
Copy link
Contributor

Manual backport of #1467

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@jmalicevic jmalicevic added the e2e Related to our end-to-end tests label Oct 11, 2023
@jmalicevic jmalicevic added this to the 2023-Q4 milestone Oct 11, 2023
@jmalicevic jmalicevic self-assigned this Oct 11, 2023
@jmalicevic jmalicevic requested a review from a team as a code owner October 11, 2023 17:01
@jmalicevic jmalicevic mentioned this pull request Oct 11, 2023
Closed
17 tasks
@cason
Copy link
Contributor
cason commented Oct 12, 2023

So we are just skipping the tests when data companion is running?

@jmalicevic
Copy link
Contributor Author

Yes for the moment, we might figure out a better way to test this meaningfully, but right now there is no way to make the tests deterministic.

@sergio-mena
Copy link
Contributor

@jmalicevic Is there an issue so we don't forget to do this?
e2e tests are the best thing we have to catch problems ATM, so I think it is important that they test a newly shipped feature such as the new pruning mechanism

@jmalicevic
Copy link
Contributor Author
jmalicevic commented Oct 12, 2023 •
edited
Loading

@sergio-mena The pruning mechanism is tested but it should not be tested here. The functionality of this test is to verify that a node has the same blocks as an archive node. Which is not really deterministically possible atm when pruning happens ad-hoc.

I am however working on reducing the flakiness of the gRPC tests which suffer from the same problem and the solution for that might be appicable here as well. #1470

@jmalicevic jmalicevic merged commit 26a3505 into v0.38.x-experimental Oct 13, 2023
@jmalicevic jmalicevic deleted the jasmina/port-e2e-fix-0.38.experimental branch October 13, 2023 07:38
lasarojc added a commit that referenced this pull request Nov 13, 2023
@jmalicevic @lasarojc
Do not race with pruning to validate headers and validators (#1467) (#…
1bf0930 
…1480)

Co-authored-by: lasaro <lasaro@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thanethomson thanethomson thanethomson approved these changes

@sergio-mena sergio-mena sergio-mena approved these changes

Assignees

@jmalicevic jmalicevic

Labels
e2e Related to our end-to-end tests
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
2023-Q4
Development

Successfully merging this pull request may close these issues.
5 participants
@jmalicevic @cason @sergio-mena @thanethomson @lasarojc
0