-
Notifications
You must be signed in to change notification settings - Fork 636
ADR-101: Backport documentation to v0.38.x-experimental #1477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* initial doc structure for data companion (#1296) * add some boilerplate content (#1296) * add boilerplate for gRPC docs (#1296) * adding more content for DC docs (#1296) * added more information for pruning retain height (#1296) * added more info to fetch data via gRPC (#1296) * more content, some refactoring and rewrite (#1296) * added info about latest height stream (#1296) * removed gRPC doc for now (#1296) * Update docs/data-companion/pruning.md Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com> * Update docs/data-companion/intro.md Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com> * changes on intro based on feedback (#1296) * better structure and content (#1296) * added info about block and tx index pruning (#1296) * minor addition (#1296) * Update docs/data-companion/pruning.md Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com> * Update docs/data-companion/grpc.md Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com> * Update docs/data-companion/grpc.md Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com> * Update docs/data-companion/pruning.md Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com> * Update docs/data-companion/pruning.md Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com> --------- Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions to improve the content added by this PR, not present in the original (backported) PR.
Co-authored-by: Daniel <daniel.cason@informal.systems> Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>
Thanks @jmalicevic @cason for the suggestions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typo, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>
Closes #1475
Manual backport of #1307
PR checklist
.changelog
(we use unclog to manage our changelog)docs/
orspec/
) and code comments