8000 Release v0.38.0 by sergio-mena · Pull Request #1337 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Release v0.38.0 #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 12, 2023
Merged

Release v0.38.0 #1337

merged 9 commits into from
Sep 12, 2023

Conversation

sergio-mena
Copy link
Contributor

Rendered CHANGELOG.md

E2E manual run on this branch: https://github.com/cometbft/cometbft/actions/runs/6158591090


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@sergio-mena sergio-mena added the release Pull requests that facilitate cutting a release label Sep 12, 2023
@sergio-mena sergio-mena added this to the 2023-Q3 milestone Sep 12, 2023
@sergio-mena sergio-mena requested a review from a team as a code owner September 12, 2023 11:53
@sergio-mena sergio-mena self-assigned this Sep 12, 2023
Copy link
Member
@hvanz hvanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following entry in the changelog needs some formatting; otherwise, LGTM.

[mempool/clist_mempool] #890 Prevent a transaction to appear twice in the mempool (@otrack)

@hvanz
Copy link
Member
hvanz commented Sep 12, 2023

The following two entries could be combined into one:

[abci] Added cli commands for PrepareProposal and ProcessProposal. (tendermint/tendermint#8656)
[abci] Added cli commands for PrepareProposal and ProcessProposal. (tendermint/tendermint#8901)

@sergio-mena
Copy link
Contributor Author

The following two entries could be combined into one

I agree with you, but this is from v0.37.0, so I'd leave it as it is

Copy link
Contributor
@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just 1 minor spelling nit, but otherwise LGTM!


This release includes the second part of ABCI++, called ABCI 2.0.
ABCI 2.0 introduces ABCI methods `ExtendVote` and `VerifyVoteExtension`.
These new metthods allow the application to add data (opaque to CometBFT),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
These new metthods allow the application to add data (opaque to CometBFT),
These new methods allow the application to add data (opaque to CometBFT),

Applying this change will require rebuilding the changelog with unclog.

@sergio-mena sergio-mena merged commit 66a5a9d into v0.38.x Sep 12, 2023
@sergio-mena sergio-mena deleted the release/v0.38.0 branch September 12, 2023 20:25
sergio-mena added a commit that referenced this pull request Sep 12, 2023
* Prepare changelog for release

* Prepare `UPGRADING.md`

* Bump version

* Fix date format

* Remove duplicate changelog entries

* Formatted #890 in changelog

* Add log entry in breaking changes for RPC block events

* Fix typo
github-merge-queue bot pushed a commit that referenced this pull request Sep 13, 2023
…38.0` (#1341)

* [cherry-pick] Release v0.38.0 (#1337)

* Prepare changelog for release

* Prepare `UPGRADING.md`

* Bump version

* Fix date format

* Remove duplicate changelog entries

* Formatted #890 in changelog

* Add log entry in breaking changes for RPC block events

* Fix typo

* Fixed `UPGRADING.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Pull requests that facilitate cutting a release
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants
0