8000 Release v0.38.0-rc3 by thanethomson · Pull Request #1124 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Release v0.38.0-rc3 #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 14, 2023
Merged

Release v0.38.0-rc3 #1124

merged 3 commits into from
Jul 14, 2023

Conversation

thanethomson
Copy link
Contributor
@thanethomson thanethomson commented Jul 14, 2023 •
edited
Loading

📖 CHANGELOG rendered

Applies two reverts:

E2E nightlies manual run for this branch: https://github.com/cometbft/cometbft/actions/runs/5555876254

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments
8000

@thanethomson thanethomson added the release Pull requests that facilitate cutting a release label Jul 14, 2023
@thanethomson thanethomson added this to the 2023-Q3 milestone Jul 14, 2023
@thanethomson thanethomson requested a review from a team as a code owner July 14, 2023 15:09
@adizere
Copy link
Member
adizere commented Jul 14, 2023

FYI @p4u

@thanethomson
version: Bump to v0.38.0-rc3
0cb7ba3 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson force-pushed the release/v0.38.0-rc3 branch from fd41a92 to 0cb7ba3 Compare July 14, 2023 15:39
@thanethomson
Remove changelog entry relating to #1121
212a246 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson
Rebuild changelog
d363908 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
andynog
andynog approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor
@andynog andynog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@thanethomson thanethomson merged commit 6d95fb6 into v0.38.x Jul 14, 2023
@thanethomson thanethomson deleted the release/v0.38.0-rc3 branch July 14, 2023 17:05
@p4u
Copy link
p4u commented Jul 16, 2023

Thanks. I'll test it ASAP.

@faddat faddat mentioned this pull request Oct 15, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andynog andynog andynog approved these changes

Assignees
No one assigned
Labels
release Pull requests that facilitate cutting a release
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
2023-Q3
Development

Successfully merging this pull request may close these issues.
4 participants
@thanethomson @adizere @p4u @andynog
0