8000 metrics: remove unused `p2p_num_txs` metric · Issue #3766 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

metrics: remove unused p2p_num_txs metric #3766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cason opened this issue Aug 20, 2024 · 0 comments · Fixed by #3767
Closed

metrics: remove unused p2p_num_txs metric #3766

cason opened this issue Aug 20, 2024 · 0 comments · Fixed by #3767

Comments

@cason
Copy link
Contributor
cason commented Aug 20, 2024

It has introduced ages ago by tendermint/tendermint#2500.

It does not make sense to measure the number of transactions exchanged at p2p level, as this information belongs to the mempool reactor. In any case, it is not currently in use.
@cason cason mentioned this issue Aug 20, 2024
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Aug 20, 2024
@cason
feat(p2p/metrics)!: removed unused p2p_num_txs metric (#3767)
d8f7a3d 
Closes #3766.

---

#### PR checklist

- [ ] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(p2p/metrics)!: removed unused p2p_num_txs metric cometbft/cometbft
1 participant
@cason
0