8000 Cosmos SDK: provide an API for accessing `state` and `store` · Issue #2610 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Cosmos SDK: provide an API for accessing state and store #2610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #578
melekes opened this issue Mar 14, 2024 · 4 comments · Fixed by #2709
Closed
Tracked by #578

Cosmos SDK: provide an API for accessing state and store #2610

melekes opened this issue Mar 14, 2024 · 4 comments · Fixed by #2709
Assignees
Labels
rfc Request for comments
Milestone

Comments

@melekes
Copy link
Contributor
melekes commented Mar 14, 2024

Feature Request

Summary

The latest version of Cosmos SDK imports state and store packages (which in v1 are internal, meaning can't be imported outside of CometBFT).

Problem Definition

Previously, the way to test something on a testnet for a single validator was by modifying the genesis.json file and skipping blocksync as indicated in #1679. A new solution was developed because exporting genesis.json can take minutes and requires lots of RAM. Instead of modifying the genesis.json file, Cosmos SDK directly modifies the chain's state and updates the store: https://github.com/cosmos/cosmos-sdk/blob/main/server/start.go#L729. For that, it needs access to state and store packages, which are currently internal.

Proposal

Either create a subset of API needed for ^ or completely reexport state and store packages.

@melekes melekes added enhancement New feature or request needs-triage This issue/PR has not yet been triaged by the team. rfc Request for comments and removed enhancement New feature or request needs-triage This issue/PR has not yet been triaged by the team. labels Mar 14, 2024
@melekes melekes added this to CometBFT Mar 14, 2024
< 8000 div class="TimelineItem-body"> @github-project-automation github-project-automation bot moved this to Todo in CometBFT Mar 14, 2024
@tac0turtle
Copy link
Contributor

thank you, let us know if we can help

@itsdevbear
Copy link

+1

@itsdevbear
Copy link

@melekes any update on this guy?

@adizere adizere added this to the 2024-Q2 milestone Mar 27, 2024
@tac0turtle
Copy link
Contributor

gentle ping, we cant move forward with comet integration in the sdk for the next release. If there is an expected timeline it would be good to know so we can share with ibc, cosmwasm, and other teams waiting on the release

@adizere adizere mentioned this issue Apr 3, 2024
31 tasks
@adizere adizere moved this from Todo to In Progress in CometBFT Apr 4, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 16, 2024
…2709)

This partly undoes the changes in #1605 by re-exporting the store/
package.

Closes #2610 

Paging @tac0turtle to check if this can help Cosmos SDK continue
migration to Comet v1

---

#### PR checklist

- [ ] ~~Tests written/updated~~
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code
comments~~
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

---------

Co-authored-by: Andy Nogueira <me@andynogueira.dev>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in CometBFT Apr 16, 2024
mergify bot pushed a commit that referenced this issue Apr 16, 2024
…2709)

This partly undoes the changes in #1605 by re-exporting the store/
package.

Closes #2610

Paging @tac0turtle to check if this can help Cosmos SDK continue
migration to Comet v1

---

#### PR checklist

- [ ] ~~Tests written/updated~~
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code
comments~~
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

---------

Co-authored-by: Andy Nogueira <me@andynogueira.dev>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
(cherry picked from commit 7d230d7)
melekes pushed a commit that referenced this issue Apr 16, 2024
…ackport #2709) (#2821)

This partly undoes the changes in #1605 by re-exporting the store/
package.

Closes #2610 

Paging @tac0turtle to check if this can help Cosmos SDK continue
migration to Comet v1

---

#### PR checklist

- [ ] ~~Tests written/updated~~
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code
comments~~
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
<hr>This is an automatic backport of pull request #2709 done by
[Mergify](https://mergify.com).

Co-authored-by: Adi Seredinschi <adizere@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfc Request for comments
Projects
No open projects
Status: Done
4 participants
0