10000 panic: non-recoverable error when signing vote · Issue #2357 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

panic: non-recoverable error when signing vote #2357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
melekes opened this issue Feb 16, 2024 · 3 comments
Closed

panic: non-recoverable error when signing vote #2357

melekes opened this issue Feb 16, 2024 · 3 comments
Labels
bug Something isn't working needs-triage This issue/PR has not yet been triaged by the team.
Milestone
2024-Q1

Comments

@melekes
Copy link
Contributor
melekes commented Feb 16, 2024

Bug Report

Setup

CometBFT version (use cometbft version or git rev-parse --verify HEAD if installed from source): v0.38.5

Have you tried the latest version: no

ABCI app (name for built-in, URL for self-written if it's publicly available): vega

Environment:

  • OS (e.g. from /etc/os-release):
  • Install tools:
  • Others:

node command runtime flags:

Config

https://download.mainnet.community/tmkms.tar.gz

What happened?

Panic during the attempted upgrade.

What did you expect to happen?

No panic.

How to reproduce it

https://download.mainnet.community/tmkms.tar.gz

Logs

 2024-02-15T10:55:54.568Z	INFO	tendermint	pex/addrbook.go:545	new bucket is full, expiring new
 2024-02-15T10:55:54.772Z	INFO	tendermint	privval/signer_listener_endpoint.go:143	SignerListener: Blocking for connection
 2024-02-15T10:55:54.773Z	INFO	tendermint	privval/signer_listener_endpoint.go:159	SignerListener: Listening for new connection
 2024-02-15T10:55:55.458Z	INFO	tendermint	privval/signer_listener_endpoint.go:187	SignerListener: Connected
 panic: non-recoverable error when signing vote (20072402/1)

 goroutine 279 [running]:
 github.com/cometbft/cometbft/consensus.(*State).signVote(0xc001d12380, 0x2, {0xc0069c3920, 0x20, 0x20}, {0xd8a11c?, {0xc0069c3940?, 0xc0060fc704?, 0x37239c0?}}, 0xc0020fed20)
 	/home/runner/go/pkg/mod/github.com/cometbft/cometbft@v0.38.5/consensus/state.go:2388 +0x639
 github.com/cometbft/cometbft/consensus.(*State).signAddVote(0xc001d12380, 0x1?, {0xc0069c3920, 0x20, 0x20}, {0x1?, {0xc0069c3940?, 0xc000bccd40?, 0x20?}}, 0xc0020fed20)
 	/home/runner/go/pkg/mod/github.com/cometbft/cometbft@v0.38.5/consensus/state.go:2439 +0x212
 github.com/cometbft/cometbft/consensus.(*State).enterPrecommit(0xc001d12380, 0x13247d2, 0x1)
 	/home/runner/go/pkg/mod/github.com/cometbft/cometbft@v0.38.5/consensus/state.go:1536 +0x1337
 github.com/cometbft/cometbft/consensus.(*State).addVote(0xc001d12380, 0xc006b12b60, {0xc006723c20, 0x28})
 	/home/runner/go/pkg/mod/github.com/cometbft/cometbft@v0.38.5/consensus/state.go:2296 +0x186f
 github.com/cometbft/cometbft/consensus.(*State).tryAddVote(0xc001d12380, 0xc006b12b60, {0xc006723c20?, 0x0?})
 	/home/runner/go/pkg/mod/github.com/cometbft/cometbft@v0.38.5/consensus/state.go:2056 +0x26
 github.com/cometbft/cometbft/consensus.(*State).handleMsg(0xc001d12380, {{0x440e4c0, 0xc0062ff978}, {0xc006723c20, 0x28}})
 	/home/runner/go/pkg/mod/github.com/cometbft/cometbft@v0.38.5/consensus/state.go:928 +0x3ce
 github.com/cometbft/cometbft/consensus.(*State).readReplayMessage(0xc001d12380, 0x3cfaf18?, {0x0?, 0x0?})
 	/home/runner/go/pkg/mod/github.com/cometbft/cometbft@v0.38.5/consensus/replay.go:82 +0x918
 github.com/cometbft/cometbft/consensus.(*State).catchupReplay(0xc001d12380, 0x13247d2)
 	/home/runner/go/pkg/mod/github.com/cometbft/cometbft@v0.38.5/consensus/replay.go:161 +0x6dd
 github.com/cometbft/cometbft/consensus.(*State).OnStart(0xc001d12380)
 	/home/runner/go/pkg/mod/github.com/cometbft/cometbft@v0.38.5/consensus/state.go:342 +0x165
 github.com/cometbft/cometbft/libs/service.(*BaseService).Start(0xc001d12380)
 	/home/runner/go/pkg/mod/github.com/cometbft/cometbft@v0.38.5/libs/service/service.go:144 +0x2f5
 github.com/cometbft/cometbft/consensus.(*Reactor).SwitchToConsensus(_, {{{0xb, 0x1}, {0xc001a4f830, 0x7}}, {0xc002b695c0, 0x14}, 0x1, 0x13247d1, {{0xc000bccd40, ...}, ...}, ...}, ...)
 	/home/runner/go/pkg/mod/github.com/cometbft/cometbft@v0.38.5/consensus/reactor.go:131 +0xb9
 github.com/cometbft/cometbft/blocksync.(*Reactor).poolRoutine(0xc001973e00, 0x0)
 	/home/runner/go/pkg/mod/github.com/cometbft/cometbft@v0.38.5/blocksync/reactor.go:406 +0xf34
 github.com/cometbft/cometbft/blocksync.(*Reactor).OnStart.func1()
 	/home/runner/go/pkg/mod/github.com/cometbft/cometbft@v0.38.5/blocksync/reactor.go:129 +0x54
 created by github.com/cometbft/cometbft/blocksync.(*Reactor).OnStart in goroutine 197
 	/home/runner/go/pkg/mod/github.com/cometbft/cometbft@v0.38.5/blocksync/reactor.go:127 +0x8b

dump_consensus_state output

Anything else we need to know
@melekes melekes added bug Something isn't working needs-triage This issue/PR has not yet been triaged by the team. labels Feb 16, 2024
@melekes melekes mentioned this issue Feb 16, 2024
Merged
4 tasks
@melekes
Copy link
Contributor Author
melekes commented Feb 18, 2024

Refs iqlusioninc/tmkms#831 (comment)

@melekes melekes mentioned this issue Feb 19, 2024
Merged
@melekes
Copy link
Contributor Author
melekes commented Feb 19, 2024

Opened iqlusioninc/tmkms#857

@melekes
Copy link
Contributor Author
melekes commented Feb 19, 2024

Closing since it's not a CometBFT issue.

@melekes melekes closed this as completed Feb 19, 2024
This was referenced Feb 20, 2024
Open
Closed
github-merge-queue bot pushed a commit that referenced this issue Feb 26, 2024
@melekes
refactor(consensus): print err from SignAndCheckVote (#2346)
e623c44 
Refs #2357

---

#### PR checklist

- [x] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
mergify bot pushed a commit that referenced this issue Feb 26, 2024
@melekes @mergify
refactor(consensus): print err from SignAndCheckVote (#2346)
5993f9b 
Refs #2357

---

#### PR checklist

- [x] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

(cherry picked from commit e623c44)
mergify bot pushed a commit that referenced this issue Feb 26, 2024
@melekes @mergify
refactor(consensus): print err from SignAndCheckVote (#2346)
cae30a2 
Refs #2357

---

#### PR checklist

- [x] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

(cherry picked from commit e623c44)

# Conflicts:
#	types/vote_test.go
@adizere adizere added this to the 2024-Q1 milestone Mar 1, 2024
@adizere adizere added this to CometBFT Mar 1, 2024
@github-project-automation github-project-automation bot moved this to Todo in CometBFT Mar 1, 2024
@melekes melekes moved this from Todo to Done in CometBFT Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs-triage This issue/PR has not yet been triaged by the team.
Projects
No open projects
CometBFT
Status: Done
Milestone
2024-Q1
Development

No branches or pull requests
2 participants
@melekes @adizere
0