10000 Tracking issue for more aggressive removal of bad peers · Issue #65 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Tracking issue for more aggressive removal of bad peers #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
6 of 9 tasks
jmalicevic opened this issue Dec 27, 2022 · 0 comments
Open
6 of 9 tasks

Tracking issue for more aggressive removal of bad peers #65

jmalicevic opened this issue Dec 27, 2022 · 0 comments
Assignees
@jmalicevic
Labels
security tracking A complex issue broken down into sub-problems

Comments

@jmalicevic
Copy link
Contributor
jmalicevic commented Dec 27, 2022 •
edited
Loading

Original issue : tendermint/tendermint#9545

Description

This issue aims to cover a wide variety of use cases where Tendermint could remove bad peers more proactively. Peer removal is triggered by information from various reactors and aims to a) increase security and b) boost performance.

There are already a number of issues created around this topic.

Definition of done

  • Define and specify bad peer behaviour. By bad behaviour we do not necessarily mean malicious behaviour. Rather, peers can be considered bad if they are slow, sending stale or unwanted messages or too frequent requests. Each issue tackling peer removal has to clearly identify what behaviour is considered bad.
  • Node is disconnected from peers upon detection of bad behaviour.
  • Changes are backported to 0.34.x
  • Changes are backported to the latest 0.37 version
  • QA tests are performed for each backport before release.

Individual issues tackling removal of bad peers

Mempool

Consensus

Blocksync

Pex/p2p
@jmalicevic jmalicevic added the backlog A prioritized task in the team's backlog label Dec 27, 2022
@jmalicevic jmalicevic self-assigned this Dec 27, 2022
@jmalicevic jmalicevic added the tracking A complex issue broken down into sub-problems label Jan 5, 2023
@thanethomson thanethomson moved this to Todo in CometBFT 2023 Jan 21, 2023
@thanethomson thanethomson added security and removed backlog A prioritized task in the team's backlog labels Apr 4, 2023
cometcrafter pushed a commit to graphprotocol/cometbft that referenced this issue Jun 1, 2024
@mergify @ValarDragon
refactor(p2p/connection): Slight refactor to sendManyPackets that hel…
c8f003d 
…ps highlight performance improvements (backport cometbft#2953) (cometbft#2978) (cometbft#61) (cometbft#65)

* refactor(p2p/connection): Slight refactor to sendManyPackets that helps highlight performance improvements (cometbft#2978) (cometbft#61)

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
(cherry picked from commit 6d0070e)

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmalicevic jmalicevic

Labels
security tracking A complex issue broken down into sub-problems
Projects
No open projects
CometBFT 2023
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thanethomson @jmalicevic
0