OPIK-1547: Add pre-computed column on ingestion to reduce overhead on aggregations #2080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backend Tests Results3 548 tests 3 545 ✅ 15m 33s ⏱️ Results for commit 2176653. ♻️ This comment has been updated with latest results. |
...pp-analytics/migrations/000024_add_output_input_pre_computed_columns_to_spans_and_traces.sql
Outdated
Show resolved
Hide resolved
andrescrz
reviewed
May 9, 2025
...pp-analytics/migrations/000024_add_output_input_pre_computed_columns_to_spans_and_traces.sql
Outdated
Show resolved
Hide resolved
...pp-analytics/migrations/000024_add_output_input_pre_computed_columns_to_spans_and_traces.sql
Outdated
Show resolved
Hide resolved
...pp-analytics/migrations/000024_add_output_input_pre_computed_columns_to_spans_and_traces.sql
Outdated
Show resolved
Hide resolved
andrescrz
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
We are adding new materialized columns so that later, the stats endpoints will use them rather than calculating the values on the fly.
Until the column materializes, Clickhouse will continue calculating the values on the fly. However, for new rows, the values will be calculated on ingestion or update. Later, probably out of peak hours, we can run the
MATERIALIZE COLUMNcommand and backfill all history.