[FEAT] Use tqdm_notebook when possble #2000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Unit Tests Results421 tests 415 ✅ 20s ⏱️ For more details on these failures, see this check. Results for commit 5e20b79. ♻️ This comment has been updated with latest results. |
alexkuzmik
requested changes
May 5, 2025
sdks/python/src/opik/evaluation/engine/evaluation_tasks_executor.py
Outdated
Show resolved
Hide resolved
SDK E2E Tests Results51 tests 42 ✅ 55s ⏱️ For more details on these failures, see this check. Results for commit b6c71af. |
SDK E2E Tests Results51 tests 42 ✅ 55s ⏱️ For more details on these failures, see this check. Results for commit 5e20b79. ♻️ This comment has been updated with latest results. |
dsblank
commented
May 5, 2025
sdks/python/src/opik/evaluation/engine/evaluation_tasks_executor.py
Outdated
Show resolved
Hide resolved
alexkuzmik
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Currently, execute uses tqdm.tqdm() always. Doesn't work well in colab or jupyter notebooks:
Not only is it plain text, but it also puts a new line for every update.
After updating:
Testing
Tests added.
Documentation
No docs needed as this is internal only.