8000 add argtypes for better autocompletion by Roger-luo · Pull Request #190 · comonicon/Comonicon.jl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add argtypes for better autocompletion #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2022
Merged

add argtypes for better autocompletion #190

merged 2 commits into from
Mar 4, 2022

Conversation

Roger-luo
Copy link
Collaborator

some special types that annotates what kind of string-like input one is expecting, this is really the ideal solution to this since the best way is still to actually have different actual types for path, filename, etc. which is currently missing in Julia, but...

@codecov
Copy link
codecov bot commented Mar 4, 2022

Codecov Report

Merging #190 (f620a37) into master (a4dfe91) will decrease coverage by 0.00%.
The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
- Coverage   82.87%   82.87%   -0.01%     
==========================================
  Files          19       20       +1     
  Lines        1285     1320      +35     
==========================================
+ Hits         1065     1094      +29     
- Misses        220      226       +6     
Impacted Files Coverage Δ
src/argtypes.jl 78.94% <78.94%> (ø)
src/ast/printing.jl 92.09% <0.00%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4dfe91...f620a37. Read the comment docs.

@Roger-luo Roger-luo merged commit 3f822e2 into master Mar 4, 2022
@Roger-luo Roger-luo deleted the roger/argtypes branch March 4, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0