Added room icons #413
Merged
Added room icons #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Airyzz
requested changes
Feb 21, 2025
Should conform to the requests for Room Icon implimentations
|
@Melechtna sorry, could you please check that this is formatted properly with Thanks! |
Not used to working with Dart, sorry, should be correct this time |
Airyzz
reviewed
Feb 21, 2025
commet/lib/ui/pages/settings/categories/app/appearance_settings_page.dart
Outdated
Show resolved
Hide resolved
Airyzz
reviewed
Feb 21, 2025
|
I noticed when I was testing there was some weird spacing problem on mobile, so I went ahead and changed it. I also made this setting default to on |
Airyzz
approved these changes
Feb 21, 2025
|
Looks good! Thanks so much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I'm unsure if this method conforms to the codebase, this correctly enables room icons. I didn't feel comfortable with modifying the tiamat codebase, so simply implemented this directly into the room_text method.