8000 system/ui: remove special currency and symbol characters from keyboard by deanlee · Pull Request #35291 · commaai/openpilot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

system/ui: remove special currency and symbol characters from keyboard #35291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

deanlee
Copy link
Contributor
@deanlee deanlee commented May 20, 2025

Removes problematic special characters (€, £, ¥, •, ?) from the keyboard specials layout that were causing display issues.

These characters aren't needed anywhere in the OP. Supporting them properly would require additional font handling and significant inputbox.py modifications that aren't necessary for the system's functionality.

before:

Screenshot 2025-05-20 13:43:02

after:

Screenshot 2025-05-20 13:41:56

@incognitojam
Copy link
Contributor
incognitojam commented May 20, 2025

I added the ? back because it's ascii, can be in Wi-Fi passwords and might be in a URL

@incognitojam incognitojam merged commit f646b4a into commaai:master May 20, 2025
15 checks passed
@deanlee deanlee deleted the pyui_keyboard_remove_special_symbol branch May 20, 2025 10:03
incognitojam added a commit that referenced this pull request May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0