selfdrive/assets: rasterize SVGs #35243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@incognitojam How about using four SVG images for the special keyboard keys (⌫, →, ⇧, ⇪) instead of managing a specific font file? This would make it simpler and more natural to render these keys in the keyboard.py render loop. What do you think? |
|
That sounds good, I'll see if I can make them? |
|
That would be fantastic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #35140 and other raylib UI
Had to switch to Inkscape instead of ImageMagick to convert as it didn't support the more complex SVGs like the experimental icon. I also updated the script to export as 512px max dimensions - some SVGs at 4x were over 4000px. It also runs optipng against the output giving ~45% savings.