8000 system/ui: fix FPS drop issues by deanlee · Pull Request #35220 · commaai/openpilot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

system/ui: fix FPS drop issues #35220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

system/ui: fix FPS drop issues #35220

merged 1 commit into from
May 14, 2025

Conversation

deanlee
Copy link
Contributor
@deanlee deanlee commented May 14, 2025 •
edited
Loading

Set VSYNC flag only when the environment variable is set to resolve FPS drop issues.

Issue Details:

  • When the VSYNC flag is set, FPS periodically drops below the expected 60 Hz: 
    FPS dropped below 60: 52
FPS dropped below 60: 53
FPS dropped below 60: 53
  • Without the VSYNC flag, the UI remains stable at 60 Hz, ensuring smoother performance.

@github-actions github-actions bot added the ui label May 14, 2025
@deanlee deanlee force-pushed the pyui_fix_fps_drop branch from 6349221 to 697256b Compare May 14, 2025 09:31
@deanlee deanlee force-pushed the pyui_fix_fps_drop branch from 697256b to b8896a1 Compare May 14, 2025 09:47
@incognitojam
Copy link
Contributor

Does this not cause any issues with screen tearing?

@deanlee
Copy link
Contributor Author
deanlee commented May 14, 2025

So far, no issues have been found, and our QT UI doesn’t enable VSYNC on startup either. so it should be ok. If needed in the future, we can enable VSYNC using environment variable

@incognitojam incognitojam merged commit c57f576 into commaai:master May 14, 2025
17 checks passed
@deanlee deanlee deleted the pyui_fix_fps_drop branch May 14, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deanlee @incognitojam
0