"docs: update 'Turn the Speed Blue' tutorial with new UI path and fu… #35016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- the change is something we merge
- include a route or your device' dongle ID if relevant
docs/how-to/turn-the-speed-blue.md
Outdated
| ## 5. Push your fork to GitHub | ||
|
|
||
| Click fork on GitHub. Then, push with: | ||
| Click **"Fork"** on the [OpenPilot GitHub repo](https://github.com/commaai/openpilot). Then push with: |
There was a problem hiding this comment.
Suggested change
| Click **"Fork"** on the [OpenPilot GitHub repo](https://github.com/commaai/openpilot). Then push with: | |
| Click **"Fork"** on the [openpilot GitHub repo](https://github.com/commaai/openpilot). Then push with: |
We always use lower case for openpilot
docs/how-to/turn-the-speed-blue.md
Outdated
| Uninstall openpilot from your device through the settings. Then, enter the URL for your very own installer: | ||
| ## 6. Run your fork on your comma device | ||
|
|
||
| Uninstall OpenPilot through the settings on your device. |
There was a problem hiding this comment.
Again lower case
docs/how-to/turn-the-speed-blue.md
Outdated
|
|
||
| ## 7. Admire your work IRL 🚗💨 | ||
|
|
||
| You’ve now successfully modified OpenPilot’s UI and deployed it to your own car! |
There was a problem hiding this comment.
Again lower case
|
@maxime-desroches I corrected the openpilot mention to all lowercase. The pr is ready to merge. Merci pour la review ! |
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
|
Pas de trouble |
|
|
||
| ## 4. Rebuild the UI | ||
|
|
||
| After making changes, rebuild Openpilot so your new UI is compiled: |
There was a problem hiding this comment.
openpilot is always lowercase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Update the "Turn the Speed Blue" tutorial in the OpenPilot docs to reflect recent code changes in the UI system. The original guide pointed to
selfdrive/ui/paint.cc, which is now outdated.This change updates:
selfdrive/ui/qt/onroad/hud.ccHudRenderer::drawText)sconsafter changesChanges Made
In
docs/TUTORIAL.md(or the file where the tutorial is located):hud.ccdrawText()function and how to modify theQColor(...)line#8080FF)Justification
paint.ccVerification
drawText()function inhud.ccis the correct place to update the speed colorsconsand confirmed that speed text displays in light blue duringtools/replay/replay --demo