8000 pandad/SPI: ensure slave is in a consistent state by adeebshihadeh · Pull Request #32645 · commaai/openpilot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

pandad/SPI: ensure slave is in a consistent state #32645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 11, 2024
Merged

pandad/SPI: ensure slave is in a consistent state #32645

merged 4 commits into from
Jun 11, 2024

Conversation

adeebshihadeh
Copy link
Contributor

No description provided.

@adeebshihadeh
Copy link
Contributor Author

@deanlee want to refactor pandad to be all in a single thread? Something like

while (true) {
  can_recv();
  can_ send();

  if (rk.frame % 10) send_panda_states();
  if (rk.frame % 50) send_peripheral_state();

  rk.keepTime();
}

@deanlee
Copy link
Contributor
deanlee commented Jun 10, 2024

wip

@adeebshihadeh adeebshihadeh changed the title pandad: max out CAN read in test pandad/SPI: ensure slave is in a consistent state Jun 11, 2024
@adeebshihadeh adeebshihadeh merged commit f8cb04e into master Jun 11, 2024
18 checks passed
@adeebshihadeh adeebshihadeh deleted the pandad-max-mode branch June 11, 2024 01:04
Edison-CBS pushed a commit to Edison-CBS/openpilot that referenced this pull request Sep 15, 2024
@adeebshihadeh
pandad/SPI: ensure slave is in a consistent state (commaai#32645)
50dd024 
* maxout

* get ready for the next one

* really get ready

* much better

---------

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: f8cb04e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adeebshihadeh @deanlee
0