cabana: draw borders around signals #27293
Conversation
|
this is the result that paint border with 1px width(setAlpha(1), darker(125)), Qt::DashLine style: I'm not sure which is better, just for your reference |
|
I guess that doesn't look great, but maybe it is OK. An alternative I can think of instead of the border would be a solid color line between MSB and LSB or only border on the bottom (arrow at end showing wrap direction when multiple lines? maybe that is overkill) |
|
I kind of like the dotted lines. |
|
I tried the dotted lines, but I don't like how they don't match up on the boundaries between bits. But if you like dash/dots more I'm happy to change it :) Dashed: Dotted: |
|
y, the dotted line is not good look. I googled for some hexview designs, and I feel that it will look better if add some padding between borders: (width:1px, margin-top-bottom:1px, margin-left-right 3~5 pix
|
|
It should look better if make binaryView more compact with small fonts. |
|
Rough draft. If you'd like to move forward with this I can clean up the gaps and ensuring the background doesn't draw beyond the outlines. |
|
y,It looks better than the origin version. what do you think? If you think it's okay too, then I'll make binview more compact based on it. |
|
Think it looks better with the padding. I won't have time till next week to clean it up though. So if you want you can also merge it as is and me or @deanlee can submit a separate PR to add the paddings. |
|
It can be merged as it as. I'll get the rest of the work done if you're busy. |
|
looks better after apply this to a compact binView:
|
|
Are you sure you want to make the binary view more compact? This is the main piece of the UI that the user interacts with when they are adding new signals. You're sitting in the car, interacting with something, and in the meantime you try to see which bits are changing. I also noticed that at the current size the UI is pretty usable on a touchscreen. Maybe you can make a checkbox to toggle between large/compact view? I imagine the compact view might be more desirable with CAN-FD. Maybe this PR is not a suitable place to discuss this though. |
|
Sorry I didn't take that into consideration, you are right. I will undo this part of the changes. |
|
the origin size: padding-top-bottom:2px: Padding 2 px seems to be clearer. |
|
2px looks good. Feel free to take my code and open a new PR if you want, then I'll close this one. |
|
This is what I was trying to describe, I think it looks pretty nice. Would probably look even better with a gray border with rounded corners that goes around both this new 4 px line as well as the MSB/LSB text. |
|
That looks great, and agree that it would be nice to get the MSB/LSB visually "attached" to the underline. |
|
looks good, but I'm worry about areas like this, if their color is similar to others, it's hard to distinguish quickly,Especially when the frequency of activities changes. |
|
Only showing MSB for these single bit signals is weird I think. Maybe we can switch it to just the colored bar about the same width as the MSB text (and remove the MSB text)? |
|
I made a table and compared the two modes, the border seems clearer and consistent.
|
|
I really like seeing the wrap direction that the color line gives you when the signal is multiple rows. I think the information might still be easier to quickly understand with the single bit fields changed to something better and the MSB/LSB integrated into the color line with border. I do like the better separation your changes have for when adjacent signals have similar colors. |
|
yes, I looooved that line too when I first saw it. but since all the color blocks are still mixed together even if there is a color line underneath, (many colors are similar). IMO, it didn't solve the most important problem we were trying to solve in the first place: distinguishing different signal and non-signal regions at a glance. |
|
|
|
The borders are a bit easier to see on my phone |
After adding bit level highlighting it was a bit harder to see where the signal edges where. This should make things more clear. Had to move LSB/MSB indicators up slightly to make everything fit.
As you can see if the shape is concave very small gaps appear at the two inside corners. If you want I can add a bunch more code to handle this case, or we leave it like this.
Before:
