Batch (.bat) file generation for assembly, launcher, and release #243 8000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds batch file generation for Windows, thus, enabling Window users to run mill without a sh environment (no repl support at the moment; see below). The resulting assembly and release .bat files are similar to the sh version where their corresponding jar file is embedded in it.
Notes:
Shifting of command line argument for interactive mode is moved to Main.main because it's difficult to do in batch for arguments with special characters
Support for ANSI color is disabled by default in Windows 10 Console; it requires a native API call to enable it. It's best to use terminal replacement such as ConEmu.
mill repl does not work because Ammonite repl assumes sh/Unix environment. I think there is still value to offer non-repl .bat version as mill CLI tools are quite nice to use and the client/server mode now provides quick turnaround to probe mill build.