8000 Remove CoursierModule#mapDependencies by alexarchambault · Pull Request #5070 · com-lihaoyi/mill · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove CoursierModule#mapDependencies #5070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove CoursierModule#mapDependencies #5070

wants to merge 3 commits into from

Conversation

alexarchambault
Copy link
Collaborator

This PR removes CoursierModule#mapDependencies altogether, and uses CoursierModule#resolutionParams instead. mapDependencies is hack that the coursier API allows, but it's too powerful IMO. A benefit of using resolution params instead is that almost anything done via resolution params can be done via the coursier command-line, which is handy to debug things.

lihaoyi
lihaoyi approved these changes May 6, 2025
View reviewed changes
Copy link
Member
@lihaoyi lihaoyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me I guess, but would be would be good to have a slightly longer explanation in the PR description of what the change means. What kind of code would be going away? What does the replacement look like?

@lefou
Copy link
Member
lefou commented May 6, 2025 •
edited
Loading

As we have users of this API, a discussion how to replace it, would be nice. E.g. my main usage is:

  • Replace some transitive dependencies (change coordinates, e.g. replace some logging impl with a different impl; switch from non-osgi to separately released osgi artifact)
  • Bump or enforce transitive versions

@vaslabs vaslabs mentioned this pull request May 9, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lihaoyi lihaoyi lihaoyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexarchambault @lefou @lihaoyi
0