8000 [collectd 6] fix: Handle metric families with zero metrics gracefully. by octo · Pull Request #4257 · collectd/collectd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[collectd 6] fix: Handle metric families with zero metrics gracefully. #4257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 29, 2024
Merged

[collectd 6] fix: Handle metric families with zero metrics gracefully. #4257

merged 8 commits into from
Jan 29, 2024

Conversation

octo
Copy link
Member
@octo octo commented Jan 26, 2024

This allows plugins to call plugin_dispatch_metric_family() unconditionally.

ChangeLog: Daemon: The plugin_dispatch_metric_family() function has been changed to handle metric families with zero metrics gracefully.

@octo octo added the core label Jan 26, 2024
@octo octo requested review from a team as code owners January 26, 2024 12:22
8000
@collectd-bot collectd-bot added the Fix A pull request fixing a bug label Jan 26, 2024
@collectd-bot collectd-bot added this to the 6.0 milestone Jan 26, 2024
eero-t
eero-t requested changes Jan 26, 2024
View reviewed changes
@octo octo force-pushed the 6/dispatch_metric_family branch from f668ba7 to 6c48b51 Compare January 26, 2024 12:47
eero-t
eero-t approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor
@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, debug message is fine.

@octo octo force-pushed the 6/dispatch_metric_family branch from d4b8b06 to 1e16c60 Compare January 29, 2024 07:55
@octo octo added the Automerge Labels PRs to be merged by a bot once approved label Jan 29, 2024
@octo octo force-pushed the 6/dispatch_metric_family branch from 1e16c60 to 208f48d Compare January 29, 2024 10:17
@octo octo merged commit 934bc36 into collectd:collectd-6.0 Jan 29, 2024
@octo octo deleted the 6/dispatch_metric_family branch January 29, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eero-t eero-t eero-t approved these changes

Assignees
No one assigned
Labels
Automerge Labels PRs to be merged by a bot once approved core Fix A pull request fixing a bug
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@octo @eero-t @collectd-bot
0