8000 Fix bug that leads to CPPFLAGS gets overridden with CFLAGS when libxm… by dago · Pull Request #3207 · collectd/collectd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix bug that leads to CPPFLAGS gets overridden with CFLAGS when libxm… #3207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2019
Merged

Fix bug that leads to CPPFLAGS gets overridden with CFLAGS when libxm… #3207

merged 3 commits into from
Jul 23, 2019

Conversation

dago
Copy link
Contributor
@dago dago commented Jul 8, 2019 •
edited
Loading

…ms is enabled

ChangeLog: Build system: Fix bug that leads to CPPFLAGS gets overridden with CFLAGS when libxmms is enabled
ChangeLog: Network plugin: Fix typo in message and formatting

rpv-tomsk
rpv-tomsk previously approved these changes Jul 10, 2019
View reviewed changes
mrunge
mrunge previously approved these changes Jul 12, 2019
View reviewed changes
@dago
Copy link
Contributor Author
dago commented Jul 19, 2019

Why is this ChangeLog check still in waiting state? I added the respective line in the description right from the start this time.

@mrunge mrunge added the Automerge Labels PRs to be merged by a bot once approved label Jul 23, 2019
@mrunge
Copy link
Member
mrunge commented Jul 23, 2019

Unfortunately, I don't have a clue how to trigger the checks again, other than adding new commits here.

If you want to add a useful commit, you could fix the typo in https://github.com/collectd/collectd/blob/master/src/network.c#L384

@dago dago dismissed stale reviews from mrunge and rpv-tomsk via 262212d July 23, 2019 11:11
@dago
8000 Copy link
Contributor Author
dago commented Jul 23, 2019

Ok, done, let's see if this works now.

@mrunge mrunge added the Maintenance A pull request without immediate user-observable impact label Jul 23, 2019
@mrunge
Copy link
Member
mrunge commented Jul 23, 2019

Thank you again for your work.

I'll just go ahead and merge this, even when we don't know why the ChangeLog check did not report anything.

@mrunge mrunge merged commit 97556a0 into collectd:master Jul 23, 2019
@mrunge mrunge added this to the 5.9.1 milestone Jul 23, 2019
@mrunge mrunge mentioned this pull request Jul 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunge mrunge mrunge approved these changes

@rpv-tomsk rpv-tomsk rpv-tomsk left review comments

Assignees
No one assigned
Labels
Automerge Labels PRs to be merged by a bot once approved Maintenance A pull request without immediate user-observable impact
Projects
None yet
Milestone
5.9.1
Development

Successfully merging this pull request may close these issues.
3 participants
@dago @mrunge @rpv-tomsk
0