8000 Upstream turbostat by chrismcn · Pull Request #3276 · collectd/collectd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Upstream turbostat #3276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2019
Merged

Upstream turbostat #3276

merged 2 commits into from
Sep 17, 2019

Conversation

chrismcn
Copy link

ChangeLog: turbostat plugin: Power metrics update for recent server CPUs.

Adding Intel server Skylake, Cascade lake and Ice Lake CPU watts telemetry. Added CPU model numbers to allow the plugin to read this CPU package telemetry.

@chrismcn
Changes for power reporting on SKX and CLX.
6d20a15 
Change-Id: I2a6e9faebe616102904bcba4bc51e8e974a56408
@chrismcn
Added ICX Xeon support model number.
efc8190 
Change-Id: I34ef3a2180a86e26d82c046a58e2862f3bc65cf5
sunkuranganath
sunkuranganath approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member
@sunkuranganath sunkuranganath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contributions.

@mrunge
Copy link
Member
mrunge commented Sep 16, 2019

Thank you for your work on this. I gave it a try.

I'm quite sure this output is not related to the change. However it looks bad to merge and not trying to fix this issue.
For reference, this is #2365

Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: cpufreq plugin: Found 8 CPUs
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: [2019-09-16 19:11:01] turbostat plugin: parse_value: Ignoring trailing garbage "-7" after derive value. Input string was "0-7".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: [2019-09-16 19:11:01] turbostat plugin: parse_value: Ignoring trailing garbage ",4" after derive value. Input string was "0,4".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: [2019-09-16 19:11:01] turbostat plugin: parse_value: Ignoring trailing garbage "-7" after derive value. Input string was "0-7".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: cpufreq plugin: File /sys/devices/system/cpu/cpu0/cpufreq/stats/time_in_state not exists or no access. P-State statistics will not be reported. Check if `cpufreq-stats' kernel module is lo>
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: [2019-09-16 19:11:01] turbostat plugin: parse_value: Ignoring trailing garbage ",5" after derive value. Input string was "1,5".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: [2019-09-16 19:11:01] turbostat plugin: parse_value: Ignoring trailing garbage "-7" after derive value. Input string was "0-7".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: turbostat plugin: parse_value: Ignoring trailing garbage "-7" after derive value. Input string was "0-7".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: [2019-09-16 19:11:01] turbostat plugin: parse_value: Ignoring trailing garbage ",6" after derive value. Input string was "2,6".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: [2019-09-16 19:11:01] turbostat plugin: parse_value: Ignoring trailing garbage "-7" after derive value. Input string was "0-7".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: turbostat plugin: parse_value: Ignoring trailing garbage ",4" after derive value. Input string was "0,4".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: [2019-09-16 19:11:01] turbostat plugin: parse_value: Ignoring trailing garbage ",7" after derive value. Input string was "3,7".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: [2019-09-16 19:11:01] turbostat plugin: parse_value: Ignoring trailing garbage "-7" after derive value. Input string was "0-7".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: turbostat plugin: parse_value: Ignoring trailing garbage "-7" after derive value. Input string was "0-7".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: [2019-09-16 19:11:01] turbostat plugin: parse_value: Ignoring trailing garbage ",4" after derive value. Input string was "0,4".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: turbostat plugin: parse_value: Ignoring trailing garbage ",5" after derive value. Input string was "1,5".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: [2019-09-16 19:11:01] turbostat plugin: parse_value: Ignoring trailing garbage "-7" after derive value. Input string was "0-7".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: [2019-09-16 19:11:01] turbostat plugin: parse_value: Ignoring trailing garbage ",5" after derive value. Input string was "1,5".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: turbostat plugin: parse_value: Ignoring trailing garbage "-7" after derive value. Input string was "0-7".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: [2019-09-16 19:11:01] turbostat plugin: parse_value: Ignoring traili
8000
ng garbage "-7" after derive value. Input string was "0-7".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: [2019-09-16 19:11:01] turbostat plugin: parse_value: Ignoring trailing garbage ",6" after derive value. Input string was "2,6".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: turbostat plugin: parse_value: Ignoring trailing garbage ",6" after derive value. Input string was "2,6".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: turbostat plugin: parse_value: Ignoring trailing garbage "-7" after derive value. Input string was "0-7".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: [2019-09-16 19:11:01] turbostat plugin: parse_value: Ignoring trailing garbage "-7" after derive value. Input string was "0-7".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: [2019-09-16 19:11:01] turbostat plugin: parse_value: Ignoring trailing garbage ",7" after derive value. Input string was "3,7".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: turbostat plugin: parse_value: Ignoring trailing garbage ",7" after derive value. Input string was "3,7".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: turbostat plugin: parse_value: Ignoring trailing garbage "-7" after derive value. Input string was "0-7".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: turbostat plugin: parse_value: Ignoring trailing garbage ",4" after derive value. Input string was "0,4".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: turbostat plugin: parse_value: Ignoring trailing garbage "-7" after derive value. Input string was "0-7".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: turbostat plugin: parse_value: Ignoring trailing garbage ",5" after derive value. Input string was "1,5".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: turbostat plugin: parse_value: Ignoring trailing garbage "-7" after derive value. Input string was "0-7".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: turbostat plugin: parse_value: Ignoring trailing garbage ",6" after derive value. Input string was "2,6".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: turbostat plugin: parse_value: Ignoring trailing garbage "-7" after derive value. Input string was "0-7".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: turbostat plugin: parse_value: Ignoring trailing garbage ",7" after derive value. Input string was "3,7".
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: Initialization complete, entering read-loop.
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: [2019-09-16 19:11:01] Initialization complete, entering read-loop.
Sep 16 19:11:00 hilbert.berg.ol collectd[31287]: unixsock plugin: No such group: `collectd'

@chrismcn
Copy link
Author

Yep, this was not caused by this pull request. Just checking..do you know is someone taking a look at this. thanks.

kkepka
kkepka approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor
@kkepka kkepka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New families numbers looks good [src].
While I agree, parsing should be fixed, I think there is still value in that commit for the release.

@mrunge
Copy link
Member
mrunge commented Sep 17, 2019

okay, the change itself looks good to me.

Just note, without fixing the parsing issue, the plugin is not usable.

@mrunge mrunge merged commit 02c7ecd into collectd:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunge mrunge mrunge approved these changes

@sunkuranganath sunkuranganath sunkuranganath approved these changes

@kkepka kkepka kkepka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrismcn @mrunge @sunkuranganath @kkepka
0