8000 Allow cURL Statistics option in write-http plugin by n2yen · Pull Request #3265 · collectd/collectd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow cURL Statistics option in write-http plugin #3265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8000
Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2020
Merged

Allow cURL Statistics option in write-http plugin #3265

merged 2 commits into from
Feb 18, 2020

Conversation

n2yen
Copy link
@n2yen n2yen commented Aug 23, 2019 •
edited
Loading

write-http can optionally configure cURL Statistics as per other cURL based plugins

ChangeLog: write_http plugin: add ability to configure cURL Statistics

@n2yen
Allow cURL Statistics option in write-http plugin
8732ee1 
write-http can optionally configure cURL Statistics as per other cURL based plugins

ChangeLog: write_http plugin: add ability to configure cURL Statistics
@n2yen n2yen force-pushed the write-http-curl-stats branch from 4a7e3ff to 8732ee1 Compare August 23, 2019 17:23
@n2yen n2yen changed the title Allow cURL Statistics option in write-http plugin Allow cURL Statistics option in write-http plugin ChangeLog: write_http plugin: add ability to configure cURL Statistics Aug 23, 2019
@n2yen n2yen changed the title Allow cURL Statistics option in write-http plugin ChangeLog: write_http plugin: add ability to configure cURL Statistics Allow cURL Statistics option in write-http plugin Aug 23, 2019
@mrunge mrunge added this to the 5.11.0 milestone Oct 16, 2019
@mrunge
Copy link
Member
mrunge commented Oct 16, 2019

Thank you for this proposal, I'll get back to this asap.

@n2yen
Copy link
Author
n2yen commented Nov 3, 2019

thanks @mrunge sure !

kwiatrox
kwiatrox reviewed Dec 2, 2019
View reviewed changes
< 8000 svg aria-label="Loading" style="box-sizing: content-box; color: var(--color-icon-primary);" width="64" height="64" viewBox="0 0 16 16" fill="none" role="img" data-view-component="true" class="my-3 mx-auto d-block anim-rotate">
@n2yen n2yen force-pushed the write-http-curl-stats branch from 3982139 to 3d0b321 Compare December 5, 2019 18:04
@n2yen
Copy link
Author
n2yen commented Dec 5, 2019

thanks for your feedback @kwiatrox - I've updated based on your comments.
cheers.

kwiatrox
kwiatrox reviewed Jan 15, 2020
View reviewed changes
Copy link
Member
@kwiatrox kwiatrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for addressing comments.

@n2yen
Copy link
Author
n2yen commented Jan 19, 2020

thanks for the review @kwiatrox !

@n2yen
Copy link
Author
n2yen commented Feb 16, 2020

Hi @kwiatrox , just checking in, is there anything else we need for review approval?

dago
dago approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor
@dago dago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dago dago merged commit 47c4fa6 into collectd:master Feb 18, 2020
@n2yen n2yen deleted the write-http-curl-stats branch February 18, 2020 15:49
@n2yen
Copy link
Author
n2yen commented Feb 18, 2020

thanks @dago !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwiatrox kwiatrox kwiatrox left review comments

@dago dago dago approved these changes

Assignees
No one assigned
Labels
Feature Pending feedback
Projects
None yet
Milestone
5.11
Development

Successfully merging this pull request may close these issues.
4 participants
@n2yen @mrunge @dago @kwiatrox
0