8000 Add ovs-dpdk extended metrics by teknoraver · Pull Request #3000 · collectd/collectd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add ovs-dpdk extended metrics #3000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
8000
Merged
merged 2 commits into from
Dec 3, 2018
Merged

Add ovs-dpdk extended metrics #3000

merged 2 commits into from
Dec 3, 2018

Conversation

teknoraver
Copy link
Contributor

Signed-off-by: Matteo Croce mcroce@redhat.com
Signed-off-by: Ryan McCabe rmccabe@redhat.com

@mrunge
Copy link
Member
mrunge commented Nov 27, 2018

Thank you, this looks good to me.

@sunkuranganath
Copy link
Member

Looks good. Thank you.

@teknoraver
Copy link
Contributor Author

ping, any update on this?

Regards,
Matteo

@mrunge
Copy link
Member
mrunge commented Dec 3, 2018

Matteo, could you please rebase your patch?

@teknoraver
Copy link
Contributor Author

It seems that ovs_stats_plugin_read() was split into ovs_stats_submit_port() and ovs_stats_submit_interfaces().
I have to carefully select where to move each element then

@teknoraver
Copy link
Contributor Au 8000 thor

c267938 refactored the whole ovs_stats_plugin_read() routine
there was no commit message, can @abays or @rpv-tomsk explain which criteria decides what to put in ovs_stats_submit_interfaces() and what in ovs_stats_submit_port()?

@abays
Copy link
Contributor
abays commented Dec 3, 2018

There was a commit message ("ovs_stats bonds support with separate interface stats"), but you are correct in that it did not provide details on the refactored ovs_stats_plugin_read(). Both ovs_stats_submit_interfaces() and ovs_stats_submit_port() take the same objects: bridge_list_t *bridge and port_list_t *port. ovs_stats_submit_port() is always called when the bridge criterion is matched, but ovs_stats_submit_interfaces() is only called if the InterfaceStats config option is true.

@teknoraver
Add ovs-dpdk extended metrics
b478f85 
Signed-off-by: Matteo Croce <mcroce@redhat.com>
Signed-off-by: Ryan McCabe <rmccabe@redhat.com>
@teknoraver
indent with contrib/format.sh
270237e
@rpv-tomsk rpv-tomsk merged commit 736d8cf into collectd:master Dec 3, 2018
@rpv-tomsk
Copy link
Contributor

Thanks for your work !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunge mrunge mrunge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@teknoraver @mrunge @sunkuranganath @abays @rpv-tomsk
0