CODEOWNERS: Add code owners as discussed at the meetup. #3053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All the names and plugin mappings look good! |
kkepka
reviewed
Feb 1, 2019
| # later match takes precedence, # @trusted-contributors will be requested for | ||
| # review when someone opens a pull request. | ||
| * @trusted-contributors | ||
|
|
There was a problem hiding this comment.
Hi, just a formal minor - as the last comment above states "These owners will be the default owners for everything in repo.", maybe we can add here a comment mentioning, that from this point we are listing plugin owners for sake of clarity.
BR, KK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to test the concept discussed in #2958.
CC: @sunkuranganath, @kwiatrox, @anaudx, @rjablonx
ChangeLog: Code ownership of five plugins has been handed out to folks from Intel.