rrdtool is broken in 5.9.1 #3232

faxm0dem · 2019-07-26T14:29:38Z

rrdtool plugin: failed to build values string

The text was updated successfully, but these errors were encountered:

faxm0dem · 2019-07-26T14:39:29Z

other plugins test for the return code of ssnprintf, e.g. nginx, postgresql, etc. so this is critical

faxm0dem · 2019-07-26T15:03:43Z

See #3153

rpv-tomsk · 2019-07-26T15:48:21Z

The reason is:

New function specification:

/* ssnprintf returns zero on success, one if truncation occurred
   and a negative integer onerror. */
int ssnprintf(char *str, size_t sz, const char *format, ...) {
  va_list ap;
  va_start(ap, format);

   int ret = vsnprintf(str, sz, format, ap);

   va_end(ap);

   if (ret < 0) {
    return ret;
  }
  return (size_t)ret >= sz;
} /* int ssnprintf */

Replaced function specification:

int snprintf (char *__s, size_t__n, const char *__fmt, ...)

Like sprintf(), but instead of assuming s to be of infinite size, 
no more than n characters (including the trailing NUL character) will be converted to s.

Returns the number of characters that would have been written to s if there were enough space.

Returns the number of characters that would have been written to s if there were enough space.

While new returns 0.

Sorry for missing this. I was in reviewers too, but has not checked that carefully enough (spent too much time fighting against Team new rules and checks).

Also affected plugin: src/threshold.c

Proposed patch:
-   if (ret < 0) {
-   return ret;
-  }
-  return (size_t)ret >= sz;
+ return ret;

But I don't know if this will recover GCC complaints...

faxm0dem · 2019-07-29T10:44:58Z

your proposed change fixes rrdtool. I'm checking if it fixes postgresql just to make sure.
@sunkuranganath will it still build on RHEL8?

sunkuranganath · 2019-07-29T21:54:57Z

@faxm0dem I dont have RHEL environment setup in our labs.
So have to defer your question to @mrunge

Change-Id: Idab2c4ffa242a73b651f1b056f85f905e356c5ac

mrunge · 2019-08-06T11:08:39Z

Should be fixed by #3237

zebity · 2019-08-16T07:23:19Z

Hi @mrunge & @rpv-tomsk ,

been away on break and saw that introduction of ssnprintf wrapper, broke some other code, my apologies.

Code snippet for wrapper was taken from here: #2895 (comment)

Also be aware that the same code snippet is in: https://github.com/collectd/collectd/blob/master/src/collectdctl.c only this time in the static function:

static int _ssnprintf(char *str, size_t sz, const char *format, ...);

The code for this is exactly as per the: ssnprintf(char *str, size_t sz, const char *format, ...);

This was done separately though as including /utils/common/common.h result in a whole new set of conflicting type errors.

So question is do we want to fix the code in collectdctl.c as well ?

Cheers,

Zebity.

mrunge · 2019-09-17T12:12:05Z

@zebity yes, we should fix everything.

zebity · 2019-09-18T08:47:15Z

Hi @mrunge I see that you have done back port from 5.9.2 into 5.9 but not back into master or 5.9.1 . I will take fork and apply fixes back into master for both /src/utils/common/common.c and src/collectdctl.c . Work now underway.

mrunge · 2019-09-18T10:34:23Z

Hi @zebity The fix I did was a cherry-pick from master, see
c80ef3c

Change-Id: Idab2c4ffa242a73b651f1b056f85f905e356c5ac

zebity · 2019-09-18T23:35:15Z

Hi @mrunge , yes saw that and to your point of "yes, we should fix everything" I have added new pull request (into master - #3283) which:

also does c 8000 herry pick of fix,
aligns collectdctl.c with this fix and
adds ssnprintf2 function to allow for future code to check for truncation error, rather than ignore it.

I have now just done review of all closed pulls to check that no-one has submitted any updates that was already doing return result check as per original broken fix, as this code would then need to be remediated to use ssnprintf2 variation rather than fixed ssnprintf (with same return behaviour as original snprintf).

My code scan found no such cases. So believe we have now "fixed everything". Question is should we now back port this into 5.9.1 ?

I have not touched 5.9.1 as you have been driving all of the 5.9.x branches (thanks very much)

Right now default version 5.8.1 (https://github.com/collectd/collectd/blob/master/version-gen.sh) and debian/canonical packages are still broken relative to qemu / virt plugin misalignment, which was fixed way back here: #3143

…5.12.0 Adam Romanek (1): daemon: make plugin_dispatch_multivalue() obey write queue limits (#2897) Adrian Boczkowski (2): redfish plugin: addressing comments from PR #2926 Fix Klocwork issues Aleksinski, MichalX (8): Corrected issues reported by klockwork intel-rdt: Changed memory allocation of new and lost pids tables from static to dynamic intel_rdt: close file descriptor on error intel_rdt: updated pqos mocks for pqos version 3.0 intel_rdt: refactored proc utils to increase efficiency utils_proc_pids: moved to utils directory intel_rdt: Fixed compile error in debug build intel_rdt: Added check if name group is defined before updating of pids list Alex White (1): Add ability to turn on collectd "debug" feature in RPMs Alexander Meshcheryakov (1): Fix linking with Python 3.8 Andralojc, WojciechX (2): intel_rdt: Update config parser for PID monitoring intel_rdt: Backwards compatibility, libpqos v1 Andrew Bays (142): sysevent plugin initial commit procevent plugin initial commit connectivity plugin initial commit check fscanf return value in process_check Use snprintf instead of sprintf clang formatting require libyajl2 to build sysevent plugin require libyajl2 to build sysevent plugin, part 2 Procevent plugin notifications connectivity notifications Clarify wanted netlink proc msgs Clarify wanted netlink interface msgs snake case for iface list + payload simplification monitor all interfaces by default payload logic clean-up + leak fixes Use ignorelist + malloc fix + conf clarification Properly detect which interfaces to monitor Use ignorelist_t and fix leaks VES-enabled sysvent plugin Only declare rsyslog keys if yajl2 present clang formatting Remove bogus include Move misplaced yajl_gen_map_close clang formatting Fix mutex lock in read_event Check ignorelist during init Connectivity RPM specfile Spec file typo fixes Add libmnl-devel req for connectivity Procevent RPM specfile Sysevent RPM specfile Use CLOCK_REALTIME for collectd-tg times (fixes issue 2219) Check for malloc failures clang formatting Fix typo in amqp1 JSON format error message ovs_stats bonds support with separate interface stats Fix implicit declaration Drain netlink socket before sleeping, then filter repeated process start msgs clang formatting Use long type for most PID values Remove types.db entry and change RegexProcess conf option name Use a separate dequeue thread to dispatch notifications Use a separate dequeue thread to dispatch notifications octo code review changes Additional mutex + styling changes More styling + remove superfluous dequeue thread error logic More styling + remove superfluous dequeue thread error logic Handled interrupted socket reads Handled interrupted socket reads Add dequeue thread + styling changes More styling + ignorelist create check use cdtime + snprintf cleanup + other styling/cleanup Styling/optimization cleanup + proper use of cdtime Styling + optimizations Document InterfaceStats option for ovs_stats plugin Small snprintf optimization More styling + optimizations Fix stop_threads call Bump CI for connectivity plugin clang formatting, again Attempt to align with new util library locations Cast cdtime_t to unsigned long long when necessary Align with new util library locations clang formatting Align with new util library locations connectivity plugin initial commit connectivity notifications Clarify wanted netlink interface msgs snake case for iface list + payload simplification monitor all interfaces by default Use ignorelist + malloc fix + conf clarification Properly detect which interfaces to monitor Connectivity RPM specfile Spec file typo fixes Add libmnl-devel req for connectivity Use a separate dequeue thread to dispatch notifications octo code review changes More styling + remove superfluous dequeue thread error logic Handled interrupted socket reads More styling + ignorelist create check use cdtime + snprintf cleanup + other styling/cleanup Styling/optimization cleanup + proper use of cdtime Bump CI for connectivity plugin clang formatting, again Attempt to align with new util library locations Cast cdtime_t to unsigned long long when necessary Remove duplicate author entry Fix clang formatting in grpc.cc procevent plugin initial commit check fscanf return value in process_check Procevent plugin notifications Clarify wanted netlink proc msgs payload logic clean-up + leak fixes Use ignorelist_t and fix leaks Fix mutex lock in read_event Check ignorelist during init Procevent RPM specfile Drain netlink socket before sleeping, then filter repeated process start msgs clang formatting Use long type for most PID values Remove types.db entry and change RegexProcess conf option name Use a separate dequeue thread to dispatch notifications Additional mutex + styling changes More styling + remove superfluous dequeue thread error logic Handled interrupted socket reads Styling + optimizations Align with new util library locations clang formatting Debian string formatting fix Another string formatting fix attempt More clang formatting for unrelated plugin connectivity plugin initial commit connectivity notifications Clarify wanted netlink interface msgs snake case for iface list + payload simplification monitor all interfaces by default Use ignorelist + malloc fix + conf clarification Properly detect which interfaces to monitor Connectivity RPM specfile Spec file typo fixes Add libmnl-devel req for connectivity Use a separate dequeue thread to dispatch notifications octo code review changes More styling + remove superfluous dequeue thread error logic Handled interrupted socket reads More styling + ignorelist create check use cdtime + snprintf cleanup + other styling/cleanup Styling/optimization cleanup + proper use of cdtime Bump CI for connectivity plugin clang formatting, again Attempt to align with new util library locations Cast cdtime_t to unsigned long long when necessary connectivity plugin initial commit Use a separate dequeue thread to dispatch notifications Handled interrupted socket reads More styling + ignorelist create check Bump CI for connectivity plugin clang formatting, again Remove duplicate author entry Bump for ChangeLog re-check Use sstrncpy instead of strncpy in sysevent plugin Check for sysevent plugin init calloc failures Andrew Smith (8): initial commit for amqp1 plugin Add notify handler fix src format Fix leak due to sender delivery not being settled Add connection retry Updates for rpm spec and review feedback Added library link check and addressed review comments Fix potential memory leaks found in ci scan Anthony Vickers (1): Add support for Modbus 64 bit vals and update docs Antoine Naud (10): src/virt.c: add lifecycle transition notifications src/virt.c: State notifications for all persistent domains src/virt.c: Fix security issue detected by klocwork related to strncat src/virt.c: Enable support for libvirt-1.3.1 src/virt.c: Fix build error on ubuntu:trusty src/virt_test.c: Fix memory leaks detected by valgrind src/virt_test.c: Fix build error on ubuntu:trusty src/virt.c: Decouple persistent notifications from refreshInterval src/virt.c: Fix one -Wshadow type warning virt: Add NULL checking to multiple config strings validation Asaf Kahlon (5): buddyinfo plugin: new plugin for memory fragmentation info buddyinfo: fix copyright authors buddyinfo: fix review comments buddyinfo: fix review comments buddyinfo: remove redundant sfree Barbara Kaczorowska (2): Fix memory leak in curl plugin Fix memory leak in curl plugin Bart De Vos (6): fix number of running processes plugin: processes: use a const ref string and strlen i.s.o. magic offset plugin: processes: return error if procs_running can not be retrieved processes: update code style Changelog: processes plugin: get # processes running from /proc/stat procs_running: added rationale into comments Baruch Siach (2): gps plugin: fix build with newer gpsd gps plugin: fix build with newer gpsd Benoit Plessis (11): Add support for SNMP Bulk Transfert Use correct coding style name error in the lately added default value setting for bulk_size Remove extraneous debug information that trigger issue with size_t variable size Add a warning when trying to activate bulktransferts on an SNMP v1 host Fix typos and try to rephrase description Fix typo and add a new 'highend switch' example that support bulk Add a warning when trying to activate bulktransferts on an SNMP v1 host -- fix formating Rephrased and simplified option documentation Fixes from ruben review Move the variable declaration closer to use Bernd Zeimetz (2): w_prometheus: fix libmicrohttpd api change Run contrib/format.sh src/write_prometheus.c. Brian ONeill (2): rrdcached plugin: changed time format to no longer lose microseconds when sending to rrdcached. rrdcached plugin: fixed issue with typing Caden (4): Support boolean input Remove empty line Don't know why empty space is removed by contrib/format.sh obey contrib format Carlos Peon Costa (1): New plugin to send values to InfluxDB using line protocol via udp. Charalampos Stratakis (1): Add Python 3.8 compatibility Charly Koza (6): Add varnish 6 support Update conf files Add varnish 6 new values Restrict workers stats to versions before v6 Split stat key on dot, extract target for SMA/SMF and use it in category Add backend name in vbe stat Chris Brown (3): Add 'quorum' stat to ZooKeeper plugin so that alerts are able to tell the difference between data lag and loss of quorum. Fix formatting. Simplified ZooKeeper quorum reporting and fixed the query-error case. Chris Mayo (3): collection3: Improve index.cgi form fieldset border style collection3: Add Type for smart_temperature collection3: Output graph.cgi debug as UTF-8 Christian Bartolomäus (1): Fix indentation of some closing curlies Christian Ekstam (1): trying again Christian Tacke (1): collection3: Show instance for Current/Voltage Christian W. Zuckschwerdt (1): Fix apache BusyWorkers/IdleWorkers Ciara Loftus (1): utils_ovs: Avoid potential access of freed memory Dagobert Michelsen (45): Include kstat.h if available to provide kstat_ctl_t Fix suggest by test clang-format Include kstat.h when available Add fallback for endianess conversion Keep clang-format happy Include config.h early or _FILE_OFFSET_BITS is wrongly defined and bails out on Solaris 32 bit Fix conditional on byteorder to work on Solaris Fix gcc issue on Mac byteorder Add endianness checks for AIX Add standard include early or _FILE_OFFSET_BITS will have definition mismatches on Solaris Make sure files in this changeset are formatted properly Use GCC-specific flags only when compiling with GCC Use pid_test only when compiling the plugin that uses it Add standard include early or _FILE_OFFSET_BITS will have definition mismatches on Solaris Make sure files in this changeset are formatted properly Use GCC-specific flags only when compiling with GCC Use pid_test only when compiling the plugin that uses it Add missing definitions for libnetsnmpagent Move Makefile rules for pid_test inside conditional for code Fix bug that leads to CPPFLAGS gets overridden with CFLAGS when libxxms is enabled Add missing definitions for libnetsnmpagent Move Makefile rules for pid_test inside conditional for code Fix typo in src/network.c Fix formatting in src/network.c Fix typo in src/network.c Fix bug that leads to CPPFLAGS gets overridden with CFLAGS when libxxms is enabled Link to libnsl.so if needed for inet_ntop() Apply clang-format to src/nfs.c Reorder conditions so that on Linux the Linux-specific code is executed instead of the more generic code for getifaddrs() clang-format on src/disk.c clang-format on cmds_test.c Warn user on unimplemented NFS stat requests on NetBSD Fix condition on libkstat existence Fix constant for max plugin name length Add sstrndup to common.c Re-add erranously removed continue Fix error/warning messages to contain more information Apply format.sh on plugin.c Fix sstrndup Add meta data documentation to exec and unixsock plugin docs Fix clang formatting Retrigger CI test which has passed but not recognized Retrigger CI Fix coding style Empty initializer when gcrypt is absent produces compile error with Sun Studio Dan Cech (1): utils_format_graphite: Add graphite tag support Dan Fandrich (1): Add OS X to the Travis build matrix. Daniel Golle (1): Add support for RS485 to modbus plugin Dheeraj Gupta (1): Add a FieldSeaparator option to tail_csv plugin Dhrupad Bhardwaj (1): Properly cleanup dropped MySQL connections. Dimitrios Apostolou (1): Add --with-libxml2 option to configure. Duane Waddle (3): write_http no longer writes http response to stdout write_http: improved logging of server response clang-format Dylan Stephano-Shachter (1): change HAVE_UDEV_H to HAVE_LIBUDEV_H for bug 2651 Edgar Fuß (37): Fix libupsclient detection Fix libtokyotyrant handling Implement NFS plugin for NetBSD Revert accidental commit to master branch Implement NFS plugin for NetBSD Address some clang-format issues Avoid $< (implied source) in non-inference rules Implement NFS plugin for NetBSD Revert accidental commit to master branch Native (sysctl) NetBSD disk plugin implementation Fix stupid merging typo Address some clang-format issues Add BUILD_NETBSD definition Remove use of undefined suppress_warning variable Add a (NetBSD-only) netstat_udp plugin Implement cpu plugin for NetBSD Implement entropy plugin for NetBSD Implement irq plugin for NetBSD Implement memory plugin for NetBSD Implement processes plugin on NetBSD Implement swap plugin on NetBSD Revert re-ordering of pagesize definition clang-format clang-format clang-format clang-format clang-format clang-format clang-format clang-format clang-format clang-format clang-format Add pagesize/getpagesize() for NetBSD case Add a Count option to snmp plugin (minus indent) Indentation changes Allow non-DS_COUNTER values for Count option Evgeny Naumov (8): add nvml module collect more stats fix formatting config: fix OB1, describe config errors changes from PR review address PR review issues fix formatting rename plugin to "gpu_nvidia" Fabrice Fontaine (4): configure.ac: fix activation of snmp_agent configure.ac: fix typo configure.ac: fix protobuf/util/time_util.h detection src/dpdk_telemetry.c: fix build on musl Florian Eckert (2): ubi: fix data source type ubi: correct code style with contrib/format.sh Florian Forster (102): daemon/common.h: Add the STRERROR() and STRERRNO macros. Tree wide: Replace sstrerror() with STRERRNO. Tree wide: Replace sstrerror() with STRERROR(). Reformat changed files. src/daemon/plugin.c: Refactor plugin_load_file(). .travis.yml: Add coverity addon. .travis.yml: Import list of dependencies from collectd-ci. .travis.yml: Try to work around travis-ci/travis-ci#1975. .travis.yml: Call coverity scan from job 1 only. .travis.yml: Send notifications to the changes ML. grpc plugin: Implement the VerifyPeer option for servers. contrib/format.sh src/grpc.cc configure: Improve detection of grpc_cpp_plugin. configure: Be more verbose about why the grpc plugin cannot be built. src/utils_taskstats.[ch]: Add library for Linux Delay Accounting. processes plugin: Implement the "CollectDelayAccounting" option. processes plugin: Check for the CAP_NET_ADMIN capability. contrib/systemd.collectd.service: Add the processes plugin. processes plugin: Make delay metric reporting less repetitive. processes plugin: Fix error message. processes plugin: Add the "delay-" prefix to type instances. processes plugin: Use the new "delay_rate" type for Delay Accounting. src/daemon/plugin.[ch]: Add the plugin name to the context. contrib/docker/rootfs_prefix: Add MIT license header. src/utils_oauth.[ch]: Add utility for OAuth authentication. src/utils_gce.[ch]: Add utility for Google Compute Engine. src/utils_format_gcm.[ch]: Implementation of the Stackdriver Monitoring API v3. write_gcm plugin: New plugin for Google Cloud Monitoring. Makefile.am: Fix rebase errors: source files need src/ prefix. src/utils_oauth_test.c: Fix oauth_create_google_json test. collectd.conf: Improve example configs. write_gcm plugin: Build only when libyajl 2 is avaiable. Rename write_gcm to write_stackdriver. Makefile.am: Build libgce ony when liboauth is available. liboauth: Make oauth_create() private and remove oauth_create_p12(). collectd.conf(5): Improve write_stackdriver documentation. write_stackdriver plugin: Use the "Label" option inside "Resource" blocks. configure: Set default value for plugin_write_stackdriver. Makefile.am: Change "noinst_LTLIBRARIES" to "EXTRA_LTLIBRARIES". configure.ac: Quote all macro args, put "if" and "then" on same line. configure.ac: Re-indent whole AC_PLUGIN list. src/utils_format_stackdriver.c: Address code review comments. Various files: Remove mode line. src/daemon/plugin.h: Fix typo in comment. src/utils_format_json.c: Remove chatty debug messages. write_stackdriver plugin: Centralize HTTP calls, add API error handling. write_stackdriver plugin: Set HTTP request timeout. write_stackdriver plugin: Check message for NULL before calling strdup(). src/daemon/common.h: Fix typo. .travis.yml: Determine number of CPUs at runtime. src/utils_format_stackdriver.c: Fix initial value of cumulative metrics. wireless plugin: Add bitrate metric. disk plugin: Drop support for Linux 2.4. Makefile.am: s/EXTRA_LTLIBRARIES/noinst_LTLIBRARIES/ src/utils_mount.c: Add code path for HAVE_GETMNTENT_R. write_stackdriver plugin: Check pointer for NULL before dereferencing it. write_stackdriver plugin: Check "http_code" instead of "status". write_stackdriver plugin: Remove redundant error message. src/daemon/util 8000 s_cache_mock.c: Add uc_meta_data_{add,get}_signed_int(). docs/review_comments.md: Start document with frequent review comments. docs/review_comments.md: Add paragraph "Define variables on first use". src/utils_oauth.c: Renew OAuth tokens 30 seconds before they expire. contrib/format.sh src/zfs_arc.c log_logstash plugin: Fix non-portable struct initialization with "{}". collectd.conf(5): Improve the tail plugin's documentation. CODEOWNERS: Add code owners as discussed at the meetup. CONTRIBUTING.md: Document the new change log requirement / behavior. write_prometheus plugin: Only use SOCK_CLOEXEC if it is defined. contrib/docker/: Install suggestions. contrib/docker/: Switch to Debian slim. contrib/docker/: Separate CMD/ENTRYPOINT. CONTRIBUTING.md: Improve wording around ChangeLog; fix example. strjoin(): Fix behavior if output buffer is NULL. CONTRIBUTING.md: Clarify our requirements for a "ChangeLog:" line. Move CONTRIBUTING.md to the docs/ directory. docs/CONTRIBUTING.md: s/test/text/ Tree wide: Move utilities and libraries to src/utils/. .travis.yml: Remove $(nproc). .travis.yml: Use the "apt" and "homebrew" add-ons. Add a unit test for the network plugin. Format src/lua.c. rrdcached plugin: Inline time conversion. Build system: enable the "df" plugin when getmntent_r() is available. configure.ac: Fix include of "utils/mount/mount.h". Makefile.am: Add gcrypt dependencies to test_plugin_network. Bump version to 5.9.0; Update ChangeLog. ChangeLog: s/Foster/Forster/ ChangeLog: Add recent bugfix merges … CODEOWNERS: Add "core maintainers" owning daemon and important plugins. CODE_OF_CONDUCT.md: Add initial Code of Conduct. CODE_OF_CONDUCT.md: Insert contact method and responsible persons. collectd.conf(5): Document the format expected by "sensors"' ignore list. ceph plugin: Initialize file descriptor to -1. types.db(5): Improve wording and document conventions. docs/CONTRIBUTING.md: Rename "master" to "main". daemon: Accept the same command line arguments, even when compiled with --disable-daemon. daemon: Use EXIT_SUCCESS and EXIT_FAILURE when calling exit_usage(). Makefile.am: Remove undefined symbol "BUILD_WITH_INFINIBAND_LIBS". network plugin: Simplify initialization of sockent_t. snmp_agent plugin: Fix strncat() truncation warning. Makefile.am: Link test_plugin_intel_rdt with libpqos. Makefile.am: Add types.grpc.pb.{cc,h} to CLEANFILES. Fᴀʙɪᴇɴ Wᴇʀɴʟɪ (26): add some useful info to libvirt manpage New upstream plugins fix deps fix comment be more verbose when plugin config cb is failing Fix return value or loglevel for several plugins better user feedback clang-format Fix return code introduced by #3182 New upstream plugins fix deps fix comment be more verbose when plugin config cb is failing Fix return value or loglevel for several plugins better user feedback clang-format Fix return code introduced by #3182 fix https://github.com/collectd/collectd/issues/3232 Don't fail if syslog loglevel doesn't match fix https://github.com/collectd/collectd/issues/3232 Don't fail if syslog loglevel doesn't match fix https://github.com/collectd/collectd/issues/3232 fix missing package in specfile Fix memory leak in write_riemann fix missing package in specfile specfile: Add support for EL8 Gordon Kelly (1): turbostat: Add support of reporting GPU power on SKL in turbostat Guillem Jover (2): Collectd::Unixsock: Remove unused $fh variables Collectd::Unixsock: Make code robust against socket errors and disconnections Harry van Haaren (1): dpdk: increase buffer size for parsing lcores Igor Peshansky (1): Factor out read_text_file_contents to ensure that data read from text files is a valid C string. Ismael Puerto (11): Remove old varnish and support for varnish 6 VSM only apply for Varnish 4 Addapt conf files clang-format Add counter for vmod-goto, only for Varnish Plus 6 Update counters for MSE 3.0 - varnish plugin clang-format remove old metrics VSM only apply for Varnish 4 or 5 Add counter for vmod-goto, only for Varnish Plus 6 Update counters for MSE 3.0 - varnish plugin Ivan Kurnosov (1): Skip `0.0.0.0` hosts in ntpd plugin Jacob Lisi (1): utils_format_graphite: add tests for graphite tag flag Jakub Jankowski (7): spec: fix mbmon/mcelog typo s/readyness/readiness/ curl plugin: add AddressFamily curl plugin: address code review comments curl plugin: re-format curl_json plugin: add AddressFamily curl_xml plugin: add AddressFamily Jan-Philipp Litza (3): nfs: Fix number of fields for NFSv4 zfs_arc: Fix skipping of leading lines zfs_arc: Read dbuf_size, dnode_size and bonus_size Jaroslaw Przybylowicz (1): Special case NaN double values for GAUGE metrics. Javier Kohen (4): Create internal library for utils_llist Expose meta_data_toc function. Update utils_cache.h Reformatted code. Jia Zhouyang (2): Add error handling for PyType_Ready Fix the return-value check of PyType_Ready John Eismeier (1): Propose fix some typos Jose M. Guisado Gomez (2): capabilities: conditionalize mhd callback return type capabilities.c: run format.sh Kamil Wiatrowski (19): pcie_errors: plugin to read PCIe errors pcie_errors: address review comments intel_rdt: multiple options are explicitly denied message log parser util: ignore patterns after message is completed pcie_errors plugin: possibility only to filter messages from log file. logparser plugin: move utils_* to src/utils exec plugin: replace select with poll capabilities plugin: new plugin to read static platform data capabilities plugin: address review comments capabilities plugin: few minor updates in comments capabilities plugin: update checks in configure.ac intel_pmu plugin: add check for lib symbol in configure.ac netlink plugin: add regular expression match for interface name netlink plugin: collect VFs info and stats netlink plugin: add unit tests for VF part netlink plugin: increase socket buffer size intel_pmu plugin: fix crash after specifying incorrect HardwareEvents names netlink plugin: additional chck for older netlink (kernel) versions Update changelog and version number for release 5.12. Kavanagh, Mark B (4): ovs_stats: fix potential NULL array dereference utils_ovs: fix potential NULL-string dereference utils_ovs: fix potential NULL utils_ovs: fix resource leaks Kevin Laatz (5): README: Include compiler defenses suggestion dpdk: fix utils_dpdk.c clang issue dpdk: fix deprecation warning dpdk: fix clang issue for deprecated function patch dpdk: fix dpdk runtime config file path Kobylinski, Michal (1): This plugin, named mdevents, is responsible for gathering the events from RAID arrays that were written to syslog by mdadm utility (which is a user-space software for managing the RAIDs). Then, based on configuration provided by user, plugin will decide whether to send the collectd notification or not. Kotlowski, Bartlomiej (2): Add NVMe attributies to SMART plugin Add NVMe attributies to SMART plugin Krzysztof Kepka (1): fix: potential null pointer dereference Krzysztof Matczak (2): Utility for filtering and parsing log messages utils_message_parser: added message buffer shrinkage Ling Huang (2): Fix unreachable clause where both tmp_plugin and tmp_plugin_instance are non-empty. cosmetic changes. Luca Boccassi (2): configure.ac: run dpdk build tests only if pkgconfig fails configure.ac: run dpdk build tests only if pkgconfig fails Luis Fernández Álvarez (1): Add a new UNKNOWN state as the initial state of metrics Luke Yeager (10): infiniband plugin: initial commit infiniband: relicense to MIT infiniband: constrain the range of GAUGE types more closely infiniband: consolidate ib_sm_lid and ib_lid infiniband: add more comments to define each attribute infiniband: run clang-format infiniband: revert the merge of ib_lid and ib_sm_lid infiniband: replace hard-coded constant with variable infiniband: fix build infiniband: fix build Maciej S. Szmigiero (4): Code files don't need execute permission Provide an udev rule with ID_SERIAL based, disk plugin usable ID attribute MQTT: Resubscribe after a reconnect Fix code style issues in src/mqtt.c Macnamara, Chris (2): Changes for power reporting on SKX and CLX. Added ICX Xeon support model number. Manoj Srivastava (1): [python-3.7-fix]: Allow compilation with Python 3.7 Manuel Luis Sanmartín Rozada (2): Allow autoload of matches and targets in the same way of plugins. clang formatting Marat Salimzianov (2): Added a comma to the list of prohibited characters Fixed utils_format_graphite_test Marc Fournier (3): Re-implement CI using cirrus-ci cirrus.yml: fix a couple of typos cirrus.yml: add --disable-dependency-tracking option by default Marco van Tol (14): Add FreeBSD support for cpufreq Fix warnings when we're unable to poll Add documentation for the FreeBSD bit for cpufreq Changes after applying contrib/format.sh create plugin ipstats Change from ips_packets to packets using type_instance Add a general note about ipstats in collectd.conf.pod Add ipstats to collectd.conf.in Note that the plugin is FreeBSD only in README Change ipstats logic to become configurable for ipv4 Change logic to use arrays for all the different options, rather then having lots of similar code. The config setup is still too-fix Apply contrib/format.sh Rewrite to use only one config array Remove unneeded warning Marius Gedminas (2): collection.cgi: parse types.db to discover DS names Apply code review suggestion Mariusz Bialonczyk (3): routeros: add support for collecting health data doc: add information about routeros CollectHealth option Fix parsing option for avoiding making BaseDir Mariusz Szafranski (1): ipmi plugin: Add SELSensor and SELIgnoreSelected config options. Mark Kavanagh (7): ovs_events: fix potential NULL pointer dereference ovs_stats: fix potential NULL dereference ovs_stats: fix potential NULL dereference utils_ovs: fix potential strcmp() NULL ptr param ovs_stats: fix potential NULL-string dereference ovs_stats: fix memory leak utils_ovs: fix potential NULL dereference Mateusz Starzyk (2): intel_rdt: PID groups change detection intel_rdt: refactor pids monitoring code. Matteo Croce (4): ovs_stats: add macro to populate counters list ovs_stats: use correct OpenFlow value Add ovs-dpdk extended metrics indent with contrib/format.sh Matthias Runge (27): Remove ProtectSystem from service file Move trusted-contributors down the list Another round of clang-format Clang-format a few files to make CI happy Add Changelog for collectd-5.9.1 Fix compile time issues RDT-compile fix Fix compile time issues Fix typo in src/java.c Add changelog to prepare 5.9.2 release Prepare 5.10 release Update the spec file to 5.10.0 Fix typo Remove grpc from Mac builds for now Remove section about self-approve patches Revert "remove old metrics" Revert "clang-format" Revert "Update counters for MSE 3.0 - varnish plugin" Revert "Add counter for vmod-goto, only for Varnish Plus 6" Revert "clang-format" Revert "Addapt conf files" Revert "VSM only apply for Varnish 4" Revert "Remove old varnish and support for varnish 6" Prepare collectd-5.11 release Replace github usernames with real names Update collectd.spec file to 5.11.0 Replace all github handles with real names Mehdi Abaakouk (1): virt: allow read Hostname from libvirt metadata Michael Kaufmann (2): exec: fix a race condition when setting environment variables Set the thread name before detaching the thread Michael Poetters (4): nut: add readout of power nut: changed type of output.realpower to energy, added output.power nut: changed type of output.realpower to realpower, added realpower type to types.db nut: split power and realpower into separate type_instances, removed realpower from types.db again Michal Humpula (1): processes: increase reading buffer for /proc/stat Michal Kobylinski (2): fixed code format fixed gather data from sensors Michał Aleksiński (1): intel_rdt: correct value metrics reported by the plugin Miroslav Lichvar (1): chrony: Ignore late responses Mozejko, MarcinX (16): virt: Add domain state metrics dispatch virt: Fix build error SNMP Agent plugin: SNMP Agent plugin: Add multiple key index support SNMP Agent plugin: SNMP Agent plugin: Redesign way of registering OIDs SNMP Agent plugin: Fix klockwork issues SNMP Agent plugin: Fix - not every OID is unregistered from snmp table SNMP Agent plugin: Fix compability with netsnmp library version < 5.4.5 SNMP Agent plugin: Fix minor issues SNMP Agent plugin: Fix coverity issues New redfish plugin Redfish plugin: Fix race condition New redfish plugin logparser plugin: Plugin used to parse log files using regexes logparser plugin: Add unit tests Mytnyk, Volodymyr (1): dpdkstats: Fix compilation issue. Märt Bakhoff (4): amqp: add tls support write_sensu: add the IncludeSource option amqp: allow multiple hosts for failover amqp: improve example conf Nathan Huff (Admin) (2): Report number of in progess disk IO requests on FreeBSD. Fix formating Nathan Ward (1): Update documentation to reflect how threads really work these days. Nelson (2): Allow cURL Statistics option in write-http plugin updates based on review comments Nikita Kozlov (1): disk: in linux, reset the disk when it disappear from diskstats Nimrod Maclomhair (3): Added a fix for new battery notation in sysfs battery.c - run clang-format. Run contrib/format.sh as required by github check PJ Bostley (2): Adding support for CDAB endian 32-bit modbus polls Adding documentation for the Modbus little endian modes where 32 bit values have thier registers swapped Pablo Llopis (21): Increase turbostat_read() resiliency when sched_getaffinity() fails formatting fixes turbostat plugin: add new setting `RestoreAffinityPolicy` Add new slurm plugin Add common node state flags Add slurm to collectd.conf.in so it is included in the auto-generated collectd.conf Add slurm and libslurm to README Add new contributions to AUTHORS clang-format slurm.c source fix merge conflict in configure.ac add slurm types Add collectd.conf manpage slurm documentation Add slurm internal stats Minor doc additions Report job states just like sinfo. Rework slurm types Use new location for common.h Add PLUGIN_NAME to all ERRORs Rework slurm types contrib/format.sh src/slurm.c slurm: compatibility with Slurm >= 20.02 Pavel Rochnyack (201): processes plugin: Fix compilation when ps_delay() not used. Tree wide: Replace sstrerror() with STRERRNO. Fix typo in collectd.conf.pod netlink plugin: Use of less strict rules in link_filter_cb() netlink plugin: Report `rx_nohandler` stats Remove empty `cmd_listval_t` data structure and related no-op code. cleanup: code formatting Added support for libi2c-4.0 Added missing include of "collectd.h" oracle plugin: Add lost udb_query_finish_result(). plugin dbi: Added lost check for udb_query_prepare_result() return value. utils_db_query: Added lost free(). utils_db_query: Removed excessive calls of udb_result_finish_result() and udb_query_finish_result(). clang-format modbus: polished code style redis plugin: polished a bit redis plugin: fix issue found by master aggregation tests redis plugin: fix issue found by master aggregation tests perl plugin: Restore missing include of "collectd.h" config parser: Improved error reporting on global options snmp plugin: Allow to set plugin value in reported metrics docs: Fix typo snmp plugin: Implemented new configuration options snmp plugin: Added types into list of requested snmp OIDS snmp plugin: Pass variable to csnmp_instance_list_add() snmp plugin: codestyle snmp plugin: Rename types and fields to more common names snmp plugin: Refactored filling cells of table snmp plugin: Implemented HostnameOID option snmp plugin: added NOTICE when suffix (row of values) is skipped snmp plugin: Replace reserved chars in hostname value snmp plugin: HostOID option implementation snmp plugin: FilterOID option implementation snmp plugin: Removed newly-added 'suffix skipped' notice snmp plugin: polished a code snmp plugin: Updated documentation for 'Ignore' option ntpd plugin: Don't treat normal peers as refclocks. ntpd plugin: Added new refclock_names rrdtool plugin: Added more error reporting redis plugin: Fixed bug of Timeout option redis plugin: Check for / report connection errors redis plugin: Change text of some error messages redis plugin: Update documentation redis plugin: Report query errors write_redis plugin: Fixed bug of Timeout option redis plugin: Implemented persistent connections redis plugin: Reworked to use plugin_register_complex_read() redis plugin: report CPU usage redis plugin: Added commands statistics reporting redis plugin: Simplified commands statistics parser snmp_agent: Replace strndup() with internal implementation redis plugin: Added option ReportCpuUsage for reported CPU consumption snmp_agent: Remove structure initialization snmp_agent: Try to fix tests snmp_agent: Try to fix tests redis plugin: Fix memleak Updated codestyle configfile.c: Use plugin name from plugin context in error reporting bind plugin: Switched to use of cf_util_get_boolean() and cf_util_get_string() core: Introduced daemon_log() for messages prefixed with plugin name common.c: Use plugin-name prefixed error reporting plugin_mmock.c: Added daemon_log() snmp_agent: Try to fix tests cleanup: cf_util_get* instead of local copy in plugins, prefixed error reporting notify_email: Include all notification parameters into email redis plugin: Report keyspace hitratio cleanup: Remove excessive error reporting redis plugin: Remove `operations_per_second` metric. statsd: Improve error reporting utils_tail_match: Fix formatting utils_tail_match: Removed unused variables utils_tail_match: Updated formatting postgresql: Set correct value to 'interval' query parameter (bugfix) core: Set 'interval' value in plugin context to match read callback interval core: Set plugin name in context when plugin is autoloaded core: Cleanup in vl->interval assignment tree-wide: Use interval value from plugin context core: Added plugin name to (some) error reporting curl_xml plugin: Added 'Interval' option curl plugin: Added 'Interval' option write_graphite: Documented 'UseTags' option write_kafka: Added Graphite tag support pcie_errors: Remove 'pcie_error' from types.db turbostat plugin: show error details routeros: Added conditionals around collect_health code routeros: Fixed check of 'Collect*' options routeros: Use 'voltage' and 'temperature' as reported types routeros: Fixed typo in 'sectors_written' metric name routeros: Fix codestyle of latest change routeros: Use MAC-address when Radio-name is missing tail_csv: Fix typo in Synopsis utils_tail: Added plugin name to error reporting utils_latency: Use plugin name from context to do error reporting processes: Fix conversion of 'delay_rate' values. Now they really have seconds per second unit. amqp1: clang-format Removed parentheses around return arguments configure.ac: Split libxml2 and libvirt mix dbi plugin: Removed excessive error reporting Minor codestyle fix redis plugin: Fix coredump when stopping Collectd with inaccessible Redis server redis plugin: Added option for connecting via UNIX socket Fix Solaris builds Fix 'make distcheck' (for `master-aggregation` hook) Fix Solaris builds Fix Solaris builds statsd: Set SO_REUSEADDR on listening socket cpufreq: Review p-state transitions metric cpufreq: Review time_in_state metric cpufreq plugin: Reviewed p-state statistics code cpufreq plugin: Address code review comments cpufreq plugin: Address code review comments cleanup: Use compound literals for SO_REUSEADDR setsockopt write_prometheus: Added 'Host' option. Added missing include of "collectd.h" virt plugin: Remove optional virDomainGetCPUStats() from main flow virt plugin: Submit `ps_cputime' only when data exists virt plugin: Move `get_pcpu_stats()' down to avoid forward declaration of `submit_derive2()' virt plugin: Cleanup swap plugin: Drop support for Linux 2.4. Request kernel version in reported issues turbostat plugin: Polished RestoreAffinityPolicy option cpufreq plugin: Limit reported value of percent to 100.1 disk plugin: Fix regression after #2955 (Drop support for Linux 2.4) contrib/docker: Install all recommended packages disk plugin: Review #2551 disk plugin: Updated after review virt plugin: Document Instances option virt: Fix indent Fix merge issue write_mongodb: Fix plugin dependencies write_mongodb: Fix plugin dependencies ovs_stats: Fix indents ovs_stats: Removed unused variable ovs_stats: Do not create ports if there is no bridge name ovs_stats: Locking reworked ovs_stats: Fix indent ovs_stats: Do not create bridge if it has not be monitored. ovs_stats: Optimize read callback sensors: Removed checks for upper limit of SENSORS_API_VERSION sensors: Removed checks for upper limit of SENSORS_API_VERSION sensors plugin: Drop support for libsensors older than 3.0.0 virt plugin: Updated InterfaceFormat documentation virt plugin: Handle ignorelists properly virt plugin: Fixed mistake in variable rename virt plugin: Move adding of devices into own functions virt plugin: New options: ReportBlockDevices and ReportNetworkInterfaces virt plugin: Add missing config_keys processes: Fix 'delay_rate' race condition processes: Reduce procstat entry 'age' limit netlink plugin: Use of less strict rules in link_filter_cb() virt plugin: Fix segfaults on shutdown virt plugin: Changed place of event loop start/stop debug messages output lua: cleanup lua plugin: don't elements from stack in `clua_store_thread`. lua plugin: free mutex on callback destroy lua plugin: Don't destroy interpreter early lua plugin: remove line feed in error message lua plugin: Make it possible to register more than one reader/writer. virt plugin: Support new metric from libvirt-5.0.0 virDomainMemoryStats() virt plugin: Cleanup excessive check virt plugin: Renamed get_domain_state() to submit_domain_state() virt plugin: Do not report 'domain_state' metric when not enabled by ExtraStats virt plugin: Do not fail if no connection on init() virt plugin: Fixed virt_notif_thread_init() place virt plugin: Added new code of virDomainShutoffReason enum virt plugin: Skip 'last_update' reporting as that is not memory but timestamp virt plugin: Split domain memory reporting to appropriate types virt plugin: do not report empty metrics virt plugin: Added debug message virt plugin: Check for virt_notif_thread_init() success virt plugin: Added support for new shutdown event details virt plugin: clang-format virt plugin: Fix typo dns plugin: Do not use headers from glibc mysql: [impr] enable uptime metric memcached plugin: Report uptime metric check_uptime: New plugin, based on new cache_event callback. virt plugin: Added ExtraStats selector 'memory' virt plugin: Added ExtraStats selector 'vcpu' virt plugin: Do not request cpu maps when not required virt plugin: Fixed typos and inconsistencies virt plugin: Disable ExtraStats selectors when unsupported by libvirt virt plugin: Added timeout to event_loop thread virt plugin: Added connection state check via virConnectIsAlive() virt plugin: minor updates after review virt plugin: Use virGetLastError() instead of virConnGetLastError() dns plugin: Do not use headers from glibc powerdns: Fix formatting, broken by clang-format powerdns: Added 'unreachables' reporting disk.c: remove unused lines daemon: Recover setlocale() call in src/daemon/collectd.c do_init() configure.ac: Removed unused checks for functions daemon: Check if plugin actually loaded before reporting configuration issues disk.c: remove unused lines daemon: Recover setlocale() call in src/daemon/collectd.c do_init() virt: Fix memory leak with libvirt MetadataXPath enabled virt plugin: Remove strdup() from MetadataXPath implementation virt: Fix memory leak with libvirt MetadataXPath enabled virt plugin: Remove strdup() from MetadataXPath implementation daemon: Fix regression caused by #3217 openvpn plugin: Fix parsing empty fields Pavel Rochnyak (3): Revert "collection.cgi: parse types.db to discover DS names" collection.cgi: Use `value` as ds_names Use real name instead of Github account Pawel Zak (2): NVMe SMART - makefile adjustments NVMe SMART - makefile adjustments Pierre Lebleu (6): UBI plugin: collect some stats about the UBIFS UBI plugin: update the ChangeLog UBI plugin: coding style update UBI plugin: take account of remarks UBI plugin: add documentation UBI plugin: enable plugin only for Linux system Radoslaw Jablonski (24): virt: Apply formatting rules on plugin code plugin_mock: Fix code formatting after virt-plugin related changes virt: Fix unit tests build with libvirt versions < 1.3 virt: Replace malloc with calloc for array allocations virt: Fix memory leak when using libvirt <= 1.0 virt: Fix code style in unit tests virt: Fix memory handling for domains data virt: Add exit condition in notif-thread loop virt unit tests: Add valgrind.suppress with libnl1 leak definition virt: Add valgrind.suppress to EXTRA_DIST virt: Remove unneeded info about thread id virt: Change '_Bool' to standard 'bool' type virt_test: Code cleanup plugin_mock: Mark params as unused in plugin-notification mocks virt: Cleanup - removed redundant true/false setting virt: Rename block_info to block_stats virt: Add information about 'source' for block device virt: Add block info statistics for block devices virt: Fetch block info stats from libvirt only if needed virt: Fix parsing configuration options virt: Fix network interface filtering virt: Fix domain filtering option collect.conf.pod: Add more info about virt filtering options virt: Add NULL checking to multiple config strings validation Rafael Marinheiro (6): utils_cache: fix pointer reference and meta_data ingestion text protocol: Add support for meta_data in PUTVAL text protocol: Require quotes for string metadata. text protocol: Run clang-format on utils_cmds_test text protocol: Fix memory leak in PUTVAL parsing. text protocol: Handle errors in set_option. Reshma Pattan (8): dpdk_telemetry plugin: add plugin for DPDK metrics via DPDK Telemetry library dpdk_telemetry plugin: remove while loop from init and read callbacks dpdk_telemetry plugin: place the plugin in sorted order dpdk_telemetry plugin: prefix missed lib dpdk_telemetry plugin: use json loads symbol in configure dpdk_telemetry plugin: fix some logs to be debug dpdk_telemetry plugin: move read loop reg to module register dpdk_telemetry plugin: refactor clean up of socket close Robert Dietrich (6): use GPU index as plugin instance fixed nvml plugin config added documentation for the two new config options of the nvml plugin replaced bit-shift with respective define replaced sizeof with NVML_DEVICE_NAME_BUFFER_SIZE (provided with nvml.h) code formatting via format.sh Rodion Vynnychenko (1): Ignore -f when compiled with --disable-daemon Romain Tartière (1): Copy MetaData to Riemann events Ruben Kerkhof (212): README: do not point users to non-existing file build.sh: look in m4 dir for macro's build.sh: use consistent indentation build.sh: fix a few cosmetic issues filecount plugin: mark function as static daemon: make function static daemon: make function static daemon: fix build warning Fix compilation on OpenBSD network_parse.c: ansify function definition configure.ac: return is not a function Do not hide prototype of check_capability() write_tsdb: ansify function declaration bind plugin: modernize the code a bit Run clang-format on src/bind.c after my change apache plugin: modernize the code a bit aggregation plugin: modernize the code a bit write_sensu: use sstrncpy Treewide: use bool instead of _Bool No need to initialize static bools to false Set static bools to true instead of 1 clang-format Use true and false for assignments to bool tcpconns: remove redundant include Don't initialize static pointers to NULL Don't initialize static numeric variables to 0 Remove unreachable break statement collectd-tg: fix warning Bind plugin: remove unused parameters curl_json_test.c: fix warnings write_sensu plugin: remove unused parameter write_riemann plugin: fix warning write_sensu plugin: use the right size for buffer snmp plugin: add some missing error handling Look for more variants of liblua Use sane CFLAGS while checking for strtok_r Fix syntax error introduced by previous collectdmon: remove unneccesary cast collectdmon: modernize the code a bit nut plugin: fix warning collectdmon: fix build failure on Xenial table plugin: modernize code a bit netlink plugin: fix truncation warnings virt plugin: fix truncation warning table plugin: fix truncation warnings Fix make distcheck on Mac OS netlink plugin: fix build warnings table plugin: fix build warning processes plugin: fix build warning amqp1 plugin: no need to initialize statics amqp1 plugin: use bool for boolean variable amqp1: clean it up a little amqp1 plugin: remove unneccesary cast virt plugin: take mutex when setting member virt plugin: set bool to false, not 0 statsd plugin: Comparison is always true because status <= -1 snmp plugin: fix scan-build warning turbostat plugin: free the right variable amqp1 plugin: fix sign compare warning ipmi plugin: fi 67E6 x sign compare warning dpdkevents plugin: fix sign compare warnings virt plugin: fix a few sign compare warnings intel_rdt: fix a bunch of warnings intel_rdt: fix format specifier ceph plugin: fix scan-build warnings collectd.c: modernize code a bit Fix out of tree builds dpdk: Ansify function prototype utils_mount.c: fix implicit conversion write_sensu plugin: fix implicit conversion utils_time.c: fix implicit conversion warning Remove unused asubst function wireless plugin: fix implicit conversion warning virt plugin: fix implicit conversion warning scanner.l: fix a few implicit conversion warnings scanner.l: use size_t for 2 variables scanner.l: modernize code a bit uuid plugin: fix implicit conversion warning unixsock plugin: fix implicit conversion warning tcpconns plugin: fix implicit conversion warnings mysql plugin: fix implicit conversion warning csv plugin: fix implicit conversion warning parser.y: fix implicit conversion warning parser.y: minor cleanup df plugin: fix implicit conversion warning ceph plugin: fix implicit conversion warnings email plugin: fix implicit conversion warning iptables plugin: fix implicit conversion warnings java plugin: fix implicit conversion warning memcached plugin: fix implicit conversion warning snmp_agent plugin: fix a few conversion warnings ceph plugin: fix a few format specifiers intel_rdt plugin: const correctness processes plugin: const correctness Stop poisoning function in debug mode Reset LDFLAGS before testing for strtok_r ceph plugin: use recommended style for calloc collectd-nagios: remove unneccesary casts barometer plugin: remove unneccesary cast cpufreq plugin: fix minor style issue daemon/plugin.c: fix minor style issue daemon/plugin.c: remove unneccesary casts daemon/plugin.c: fix two more stylistic issues daemon/types_list.c: fix minor style issue daemon/utils_cache.c: fix minor style issue disk plugin: fix minor style issue gmond plugin: fix minor style issues intel_pmu plugin: fix some minor style issues intel_rdt plugin: fix some minor style issues ipmi plugin: remove unneccesary cast java plugin: fix minor style issue libcollectdclient: fix minor style issue liboconfig: fix minor style issues oracle plugin: remove unneccesary cast ovs_stats plugin: fix some stylistic issues postgresql plugin: fix some stylistic issues snmp_agent plugin: fix minor nit utils_db_query.c: fix some minor style issues utils_ovs.c: fix some minor stylistic issues utils_rrdcreate.c: fix minor style issue virt plugin: fix some minor style issues xencpu plugin: fix minor style issues Ignore test-suite.log in all directories Fix a couple of warnings in test suite Fix build Treewide: do NUL-termination correctly Rewrite configure check for CUDA collectd.conf(5): fix a few typos collectd.conf(5): finish a sentence libcollectdclient: fix gcc warning libcollectdclient: fix minor cosmetic issue Run make distcheck instead of make && make check Travis: remove obsolete option Travis: switch to Xenial Travis: disable dependency tracking Travis: do a verbose autoreconf Travis: use newer Xcode image Travis: install the right dependency on Xenial Travis: only use clang on OSX Travis: build collectd with debug enabled Travis: explicitly set compiler to clang on OSX Travis: install dependency for amqp1 plugin on OSX Travis: silence git clone Travis: we don't use submodules Travis: fetch just the tip of the git branch Travis: Use two cores to run make Travis: try to make mysql plugin build on OSX Travis: try to fix protobuf header detection Travis: try to fix env settings rrdcached plugin: use same attribute name for both prototypes rrdcached plugin: use designated structure initializer rrdcached: a few minor cleanups Handle failure of simple config callbacks Do not suggest to read the logs if parsing config fails Clarify error message a bit Reduce the amount of output from ./configure collectd.conf(5): fix a typo Fix some rendering issues in collectd-lua(5) lua plugin: cleanup properly when shutting down Reduce the nr of allocations when parsing types.db Please clang Don't hide errors when creating manpage sensu plugin: fix compiler warning when build with --enable-debug pod2man: remove --errors argument Cirrus CI: do not clone the full branch Cirrus CI: enable parallel builds ovs_stats plugin: fix compiler warning turbostat plugin: fix two compiler warnings virt plugin: fix compiler warning oauth.c: fix compiler warning write_prometheus plugin: fix compiler warning intel_rdt plugin: fix compiler warnings Cirrus CI: remove Wheezy Cirrus CI: remove Fedora 26 Cirrus CI: use clang++ where we use clang Cirrus CI: remove musl-libc job configure.ac: keep the list of plugins sorted collectd_network.py: remove unused import collection3: remove unused variable common.c: remove always true comparison netlink.c: remove always true comparison browser.js: declare a few vars used as locals treewide: fix a few missing include guards Only include <sys/sysctl.h> when needed Fix warning in test_escape_slashes Fix warning in test_escape_string Fix warning in test_strunescape clang-format Travis: switch to Bionic Disable lvm plugin in Travis for now Travis on MacOS: bump image version Log which packages pkg-config thinks we have Remove LVM plugin Sort output of pkg-config Install a few deps Try to use java Show config.log for debugging Try to point OSX at where java is Stop installing libstatgrab Fix warning in test_escape_slashes Fix warning in test_escape_string Fix warning in test_strunescape Fix warning in test_escape_slashes Fix warning in test_escape_string Fix warning in test_strunescape gpu_nvidea plugin: fix build Fix compilation with libcuda gpu_nvidea plugin: fix build Fix compilation with libcuda Remove trailing whitespace in collectd.conf collectd.conf.pod: remove trailing whitespaces Remove duplicate plugin author from AUTHORS Ryan McCabe (5): turbostat: Fix parsing warnings turbostat: Fix parsing warnings amqp1: Fix leaks on error paths network: Add missing freeaddrinfo on error path. amqp1: Add option to limit internal send queue length SK (1): mysql: [impr] enable uptime metric Sarah Fischmann (3): add support for humidity in sensors plugin add humidity for lm_sensors version >= 0x402 add humidity for lm_sensors version >= 0x431 Sean Campbell (2): Refactor collectd binary to separate Unix-specific code. Base port to Windows (#2810) Sebastian Harl (1): grpc plugin: Fixed typo in an error message. Sebastian Schmidt (1): Remove duplicate switch case. Self-Perfection (1): mysql: Compatibility with MariaDB >= 10.5 Sexton, Rory (6): Extending turbostat plugin to report the following platform metrics: Extending turbostat plugin to report the following platform metrics: Extending cpufreq plugin to read the following additional metrics: Updating cpufreq.c from clang-format Addressing comments on previous commit. Clang format Shirly Radco (1): Add write_syslog output plugin Starzyk, MateuszX (4): intel_rdt: adds pids extraction for given processes list intel_rdt: add PQOS API stubs for pid monitoring. intel_rdt: collect data for monitored processes intel_rdt: update unit-tests for process monitoring TG, Hari (5): dcpmm plugin collects performance and health statistics from Intel Optane DC Presistent Memory (DCPMM). Updated the CollectHealth and CollectPerfMetrics config value types to boolean. Improved error handling in case of init and read callback, and collection thread failures. Updated REDME with library upstream URL. Updated AUTHORS. Updated a few metrics names and descriptions to be more intuitive. Takuro Ashie (5): Makefile.am: Remove a needless tab regex match: Fix unexpected match with empty meta data regex match: Fix unexpected match with empty meta data match_regex: Accept all data types of meta data network plugin: Add a new metadata "network:ip_address" Tamas TEVESZ (1): Fix routeros unset radio-name showing up as "(null)" Thomas Mieslinger (4): mysql: report slave status running io and sql replace slave_running with generic bool replace long if else with compact code run format.sh to comply with coding style Théophane Charbonnier (2): Zookeeper - Add missing Mntr fields Zookeeper - Add missing 3.5 mntr fields Toshiaki Takahashi (3): write_redis: fix "max_set_duration" deletes unexpected data Fix collecdmon not start collectd run contrib/format.sh src/collectdmon.c Tyler Harper (1): add Import configuration option to collectd-python documentation U-COLLECTD-WIN201\campbellsean (1): Enable additional plugins on Windows. Wiatrowski, KamilX (1): intel_pmu plugin: support for uncore multi pmu Wilfried Goesgens (13): styleguide fix warning implement sourcecode review add jolokia documentation & configuration implement review sugestions. rename value, add intermediate pointer format fix syntax fix include lint future yjail future yjail add helper scripts William Pursell (2): Cleanup version-gen.sh Docs: use "its" vice "it's" where appropriate Wojciech Andralojc (1): Fix for CI error in test code on epel6 platform. YmrDtnJu (1): zfs_arc: Ignore the first two lines of the statistics file on Linux. Yousong Zhou (3): types.db: fix ping_droprate range spec exec: free up memory on shutdown network: fix data race when accessing sending_sockets Zebity Spring (24): Add snprintf wrapper for GCC 8.2/3 Run all changed files 68 8.c/1*.h through clang-format Run all changed files 68 8.c/1 *.h through clang-format agin.. Run all changed files 68 8.c/1*.h through format.sh web util Merge upstream, address conflict in src/utils/cmds/cmds_test.c run all updated *.h *.c through clang-format again Run contrib/format.sh across entire *.h/*.c source tree (1st of 2) Run contrib/format.sh across entire *.h/*.c source tree (2nd of 2) Merge upstream, address conflict in src/utils/cmds/cmds_test.c Add snprintf wrapper for GCC 8.2/3 Run all changed files 68 8.c/1*.h through clang-format Run all changed files 68 8.c/1 *.h through clang-format agin.. Run all changed files 68 8.c/1*.h through format.sh web util Make return result consistent with fixed src/utils/common/common.c - ssnprintf wrapper Add second wrapper ssnprintf2 to allow introduction of error handling on truncation in future Add ssnprintf2 wrapper variiant definition Avoid using sysctl on linux Avoid using sysctl on linux Avoid using sysctl on linux Avoid using sysctl on linux Avoid using sysctl on linux Avoid using sysctl on linux Avoid using sysctl on linux & allow for OpenBSD case Format BSD constrained sysctl usage bkotlowski (1): Add missing licences headers and fix overflown integer during conversion campbellsean@google.com (3): Replace zu with PRIu64 and llu with new macro, PRIsz, which will make it easier to make the code platform-independent. Add GNULIB_DIR to LDFLAGS in configure.ac on Windows Fix warning that pkgdatadir and pkglibdir were previously defined. cekstam (4): Add scale and shift to modbus plugin correcting all the wrongs Read CONTRIBUTING.md, but obviously got it wrong Now with updated clang-format elieyal (11): Add Bind Address option Fixed all comments Fixed additional comments upddated correct file Fixed leak and hint Fixed all comments by @rubenk networ…

faxm0dem mentioned this issue Jul 26, 2019

WIP: fix rrdtool #3233

Closed

This was referenced Jul 29, 2019

Plugin syslog failed to handle option LogLevel, return code: 1 #3236

Closed

Plugin iptables failed to handle option Chain, return code: 1 #3235

Closed

faxm0dem pushed a commit to ccin2p3/collectd that referenced this issue Jul 29, 2019

fix collectd#3232

d27bfc7

Change-Id: Idab2c4ffa242a73b651f1b056f85f905e356c5ac

This was referenced Jul 29, 2019

fix ssnprintf wrapper #3237

Merged

collectd -t should test config #3216

Open

mrunge added the Bug A genuine bug label Jul 30, 2019

mrunge self-assigned this Jul 30, 2019

mrunge added this to the 5.9.2 milestone Jul 30, 2019

mrunge closed this as completed Aug 6, 2019

zebity pushed a commit to zebity/collectd that referenced this issue Sep 18, 2019

fix collectd#3232

8cae217

Change-Id: Idab2c4ffa242a73b651f1b056f85f905e356c5ac

mrunge mentioned this issue Oct 11, 2019

Merge stable branch back to master #3299

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rrdtool is broken in 5.9.1 #3232

rrdtool is broken in 5.9.1 #3232

rrdtool is broken in 5.9.1 #3232

rrdtool is broken in 5.9.1 #3232

Comments