This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fixing issue for CUDA feautre extraction #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using THROW_CHECK_EQ(options_.max_image_size, sift_gpu->GetMaxDimension()); causes issues for me when using CUDA as I don't seem to be able to set the parameter right. It seems wrong to me to expect that max_image_size is set to GetMaxDimension, as the latter will be device-dependent. Using THROW_CHECK_LE seems more appropriate.
|
Not sure why CI is failing now but it's unrelated to this PR. Regarding the changes, looks good to me (adding Philipp who wrote the code for SIFT GPU). It's strange nobody ran into this in COLMAP since there is a similar check https://github.com/colmap/colmap/blob/dev/src/feature/sift.cc#L862-L866 |
|
Indeed. This looks strange as well. |
|
Hi all, yeah I copied this from CPU SIFT. |
Phil26AT
approved these changes
Apr 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using THROW_CHECK_EQ(options_.max_image_size, sift_gpu->GetMaxDimension()); causes issues for me when using CUDA as I don't seem to be able to set the parameter right. It seems wrong to me to expect that max_image_size is set to GetMaxDimension, as the latter will be device-dependent. Using THROW_CHECK_LE seems more appropriate.