DaskVine Dag Reconstruction, Visualization + other fixes #4145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btovar
requested changes
Apr 28, 2025
| self.set_result(p, self.get_result(node.key)) | ||
| ) # case e.g, "x": "y", and we just set the value of "y" | ||
| x = self.set_result(p, self.get_result(node.target)) | ||
| # rs.update(x) # case e.g, "x": "y", and we just set the value of "y" |
| @@ -162,10 +234,14 @@ def set_result(self, key, value): | |||
| else: | |||
| self._depth_of[r] = 0 | |||
|
|
|||
| for c in self._dependencies_of[key]: | |||
| self._pending_needed_by[c].discard(key) | |||
| if not DaskVineDag.taskref(self._working_graph[key]): | |||
|
|
||
| return rs.values() | ||
| if DaskVineDag.taskref(self._working_graph[key]): | ||
| return rs |
There was a problem hiding this comment.
Is this mixing old and new graph styles? If so, this file should only have the new style, and the one in compat the old style.
| @@ -211,6 +290,33 @@ def set_targets(self, keys): | |||
| def get_targets(self): | |||
| return self._targets | |||
|
|
|||
| def visualize(self, name='DaskVine_DAG'): | |||
There was a problem hiding this comment.
Would this be different from dask.visualize?
| dag = DaskVineDag(dsk) | ||
| dag = DaskVineDag(dsk, reconstruct=self.reconstruct, merge_size=self.merge_size) | ||
|
|
||
| if self.visualize: |
There was a problem hiding this comment.
I think we want to leave the visualization to dask proper.
| @@ -56,7 +57,7 @@ def containerp(s): | |||
| def symbolp(s): | |||
| return isinstance(s, dts.DataNode) | |||
|
|
|||
| def __init__(self, dsk): | |||
| def __init__(self, dsk, reconstruct=False, merge_size=2): | |||
There was a problem hiding this comment.
Please add detailed comments of what these options do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adds some functionality to DaskVine with a couple of fixes as well
Task Graph Reconstruction
A user annotates a function with the
@daskvine_mergedecorator. When the DaskVineDag object is created andreconstruct=True,expand_mergewill reconstruct the graph to perform a hierarchical merge/reduction based onmerge_size, which is 2 by default. We replace the original node in the graph with the root node of the hierarchical treeThis turns a DAG like this
original.pdf
To one like this
reconstructed.pdf
Visualization
The visualize function in
dask_dag.pyallows users to visualize the graph. Settingvisualize=Truewill create a dot graph. This is done after reconstruction.other fixes
In
set_resulttaskrefs, more specifically, dts.Alias is not handled properly.Merge Checklist
The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.
make testRun local tests prior to pushing.make formatFormat source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lintRun lint on source code prior to pushing.