feat: add signoz template #5386
Conversation
…etry, SMTP and email sending for Alert Manager
|
Is there any way to ignore the example secret from the XML, since it's not a real secret? |
|
@GauthierPLM Outstanding work! I just deployed it to test and it works. Two questions
|
|
Hi @pkudinov
Since the docker compose exposes ports 4317 & 4318, you could also use the signoz service URL to call your machine, as long as the DNS return the machine IP (so no Cloudflare proxy).
|
|
4317&4318 are exposed and all good. I had to map them to subdomains in Cloudflare and all good. But JSON logs are not working through tracing, they require port |
|
@pkudinov in this case, I will keep them no exposed and will let users do the setup would it be needed. This will follow the official behavior and (hopefully) save some confusion. |
|
Maybe this issue will not occur when actually using the template over the UI, but for me, when using the template via a Docker Compose Service in Coolify, I had permissions issues with the After manually 777'ing the files in the |
@flawnn do you have more details on the error you encountered? I haven't found any issue on my side. |
|
+1 |
|
Shouldn't the container named init-clickhouse share the same volume as the actual clickhouse container |
|
sorry to bother, but is there any context to this being closed, or is this just dropped? |
|
It was a mistake, sorry. I recreated the |
|
@GauthierPLM The compose file is quite large. Is there a way to make it simpler to make it more maintainable? |
|
@peaklabs-dev I think there would be two ways to improve the template maintainability:
@prashant-shahi do you think we could move forward with any of these topics so the template could be integrated in Coolify? |
|
Sounds good, please test this thoroughly and remove any unnecessary comments and containers to slim down the template as much as possible and let me know once everything works. |
|
+1 |
|
Hey @GauthierPLM |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
af4bb0c to
ade1a72
Compare
|
I updated the template to use the new tags added by the SigNoz team + reduced the template size by only bundling the config that change. Tests are more than welcome to confirm everything works as expected, especially with the config change. |
| # port: 8080 | ||
|
|
||
| services: | ||
| init-clickhouse: |
There was a problem hiding this comment.
Should this container ever restart, or only run once?
There was a problem hiding this comment.
It should only run when the compose is up to initialize Clickhouse and download the histogram-quantile user script. Once it executes successfully, it's not needed anymore.
| options: | ||
| max-size: 50m | ||
| max-file: "3" | ||
| ports: |
There was a problem hiding this comment.
Are these port mappings needed? Can these not be covered by a domain (magic env)?
There was a problem hiding this comment.
I exposed both ports with the following env vars:
- SERVICE_FQDN_OTELCOLLECTORGRPC_4317
- SERVICE_FQDN_OTELCOLLECTORHTTP_4318
However, in the UI I only had one of them showing up in the service domains.
Can I assume both ports will still be opened? I wasn't sure about Coolify behavior here so I mapped both ports.
Here is the settings just after deploying the template:
Edit: I get the same behavior with this naming scheme too:
- SERVICE_FQDN_OTELCOLLECTOR_4317
- SERVICE_FQDN_OTELCOLLECTOR_4318
| max-size: 50m | ||
| max-file: "3" | ||
|
|
||
| schema-migrator-async: |
There was a problem hiding this comment.
Why do we need a sync and async migrator?
Changes
Issues
Further testing and improvement suggestions are welcome! :)
In particular, I am not sure my approach is the best one to expose the OTEL collector.