-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat(services): Gitea security & Passbolt icon update #5899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
feat(services): Gitea security & Passbolt icon update #5899
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please test you changes as it is currently not working. Also make sure that all variables are configurable
environment: | ||
- SERVICE_FQDN_GITEA_3000 | ||
- USER_UID=1000 | ||
- USER_GID=1000 | ||
# Domain configuration | ||
- GITEA__server__ROOT_URL=${GITEA_SERVER_ROOT_URL} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be set to the auto-generated URL.
environment: | ||
- SERVICE_FQDN_GITEA_3000 | ||
- USER_UID=1000 | ||
- USER_GID=1000 | ||
# Domain configuration | ||
- GITEA__server__ROOT_URL=${GITEA_SERVER_ROOT_URL} | ||
- GITEA__server__DOMAIN=${GITEA_SERVER_DOMAIN} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be set to the auto-generated Domain.
- GITEA__service__DEFAULT_USER_VISIBILITY=${GITEA_SERVICE_DEFAULT_USER_VISIBILITY:private} | ||
|
||
# Additional Security | ||
- GITEA__security__INSTALL_LOCK=true # Lock the installation to prevent unauthorized access |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make these variables all configurable with defaults
Pull Request: Gitea Security Enhancements & Passbolt Icon Update
This PR incorporates essential security improvements for the Gitea template and updates the Passbolt icon. It addresses feedback from a previous, unmerged pull request: #4524.
Changes
Issues fixed
During a review of existing Gitea templates, I identified significant security vulnerabilities in their default configurations. To mitigate these risks, I've updated the primary Gitea template to include the following security best practices:
This comprehensive update aims to provide a more secure Gitea deployment experience by defaut for all users.