8000 Add gitlab shorthand by hackebrot · Pull Request #963 · cookiecutter/cookiecutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add gitlab shorthand #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 24, 2017
Merged

Add gitlab shorthand #963

merged 4 commits into from
Jun 24, 2017

Conversation

hackebrot
Copy link
Member

Nothing much to add here 😁

I think we should support a GitLab abbreviation.

Please let me know your thoughts! Ty 🍪

@hackebrot hackebrot added the enhancement This issue/PR relates to a feature request. label Jun 24, 2017
@hackebrot hackebrot requested a review from michaeljoseph June 24, 2017 13:58
@codecov-io
Copy link
codecov-io commented Jun 24, 2017 •
edited
Loading

Codecov Report

Merging #963 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #963   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          17     17           
  Lines         685    685           
=====================================
  Hits          685    685
Impacted Files Coverage Δ
cookiecutter/config.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3a70a9...9b4c073. Read the comment docs.

michaeljoseph
michaeljoseph approved these changes Jun 24, 2017
View reviewed changes
Copy link
Contributor
@michaeljoseph michaeljoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hackebrot
Copy link
Member Author

Thank you for the quick review @michaeljoseph! 🍪

@hackebrot hackebrot merged commit c1463b3 into cookiecutter:master Jun 24, 2017
@hackebrot hackebrot deleted the add-gitlab-shorthand branch June 24, 2017 16:31
hackebrot added a commit that referenced this pull request Jun 24, 2017
@hackebrot
Update HISTORY.rst for #963
ba5ba8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6048
Reviewers

@michaeljoseph michaeljoseph michaeljoseph approved these changes

Assignees
No one assigned
Labels
enhancement This issue/PR relates to a feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hackebrot @codecov-io @michaeljoseph
0