load custom extensions in pre-hook #860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #860 diff @@
====================================
Files 16 16
Lines 661 663 +2
Methods 0 0
Messages 0 0
Branches 0 0
====================================
+ Hits 661 663 +2
Misses 0 0
Partials 0 0
|
|
I have no idea where |
|
Hi @cheungnj! 👋 Thank you for resolving this issue. Great work! Don't worry too much about the code coverage. I don't really see a reason why your changes would cause I'm happy to merge this. Let's see what the others think. |
michaeljoseph
suggested changes
Dec 5, 2016
| @@ -106,23 +105,25 @@ def run_script_with_context(script_path, cwd, context): | |||
| mode='wb', | |||
| suffix=extension | |||
| ) as temp: | |||
| output = Template(contents).render(**context) | |||
| template = env.from_string(contents) | |||
There was a problem hiding this comment.
Could we just instantiate StrictEnvironment here, instead of passing the env through all these function calls?
michaeljoseph
approved these changes
Dec 6, 2016
|
Thank you @cheungnj! 🍪 |
hackebrot
added a commit
that referenced
this pull request
Dec 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #850
StrictEnvironment is used instead of Template when processing the pre-hook. I changed the hooks for the tests because strings weren't getting returned.