8000 Encode the result of the hook template to utf8. by ionelmc · Pull Request #578 · cookiecutter/cookiecutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Encode the result of the hook template to utf8. #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2015
Merged

Encode the result of the hook template to utf8. #578

merged 1 commit into from
Nov 10, 2015

Conversation

ionelmc
Copy link
Contributor
@ionelmc ionelmc commented Nov 5, 2015

Fixes #577.

@ionelmc
Copy link
Contributor Author
ionelmc commented Nov 5, 2015

Lets see if there's horrendous breakage ...

@codecov-io
Copy link

Current coverage is 98.40%

Merging #578 into master will not affect coverage as of c1aff93

@@            master   #578   diff @@
=====================================
  Files           12     12       
  Stmts          501    502     +1
  Branches         0      0       
  Methods          0      0       
=====================================
+ Hit            493    494     +1
  Partial          0      0       
  Missed           8      8

Review entire Coverage Diff as of c1aff93

Uncovered Suggestions

  1. +0.80% via ...iecutter/generate.py#233...236
  2. +0.40% via ...ookiecutter/utils.py#27...28
  3. +0.40% via ...okiecutter/config.py#19...20

Powered by Codecov. Updated on successful CI builds.

@hackebrot hackebrot added bug This issue/PR relates to a bug. needs-review PR Only: This PR require review from other developer labels Nov 5, 2015
@hackebrot
Copy link
Member

👍

@hackebrot hackebrot mentioned this pull request Nov 10, 2015
Closed
pydanny added a commit that referenced this pull request Nov 10, 2015
@pydanny
Merge pull request #578 from ionelmc/patch-3
743680b 
Encode the result of the hook template to utf8.
@pydanny pydanny merged commit 743680b into cookiecutter:master Nov 10, 2015
@hackebrot
Copy link
Member

Thank you @ionelmc! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. needs-review PR Only: This PR require review from other developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ionelmc @codecov-io @hackebrot @pydanny
0